fix: bump agent-framework>=1.4.0 to resolve dependency conflict#155
Merged
hectorhdzg merged 2 commits intoMay 20, 2026
Merged
Conversation
agent-framework 1.0.0 pins agent-framework-core==1.0.0 which conflicts with agent-framework-durabletask requiring agent-framework-core>=1.4.0. Also fix singleton test isolation in openai_agents test.
hectorhdzg
requested review from
MSNev,
jeremydvoss,
lzchen and
rads-1996
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the agent-framework dependency floor to avoid a transitive agent-framework-core version conflict, and adjusts OpenAI Agents instrumentor tests to better isolate singleton state between test cases.
Changes:
- Bump
agent-frameworkextra requirement from>=1.0.0to>=1.4.0to resolve dependency conflicts. - Update
TestA365OpenAIAgentsInstrumentorsetup/teardown to reset singleton instance state between tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/openai_agents/test_trace_instrumentor.py | Changes singleton reset strategy in tests to improve isolation across test cases. |
| pyproject.toml | Raises minimum agent-framework version to avoid dependency conflicts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacksonWeber
approved these changes
May 20, 2026
rads-1996
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-framework 1.0.0 pins agent-framework-core==1.0.0 which conflicts with agent-framework-durabletask requiring agent-framework-core>=1.4.0.
Also fix singleton test isolation in openai_agents test.