feat(jdtls): upgrade to vscode-java v1.40.0 with Java 21 for macOS ARM64 fix by gruckion · Pull Request #128 · microsoft/multilspy

gruckion · 2025-12-11T20:23:09Z

Summary

This PR fixes macOS ARM64 completions returning 0 items by:

Upgrading vscode-java from v1.23.0 to v1.40.0 for all platforms
Upgrading bundled JRE from Java 17 to Java 21.0.6
Fixing osx-arm64 configuration to use correct darwin-arm64 binary

Problem

On macOS ARM64 (Apple Silicon), Eclipse JDTLS completions returned 0 items while other features (hover, go-to-definition) worked correctly.

Root Causes

Wrong binary downloaded: The osx-arm64 config was downloading the wrong vsix file (darwin-x64 instead of darwin-arm64)
Broken JRE: The bundled JustJ JRE (Java 17) has broken jspawnhelper on macOS ARM64, causing posix_spawn failures when JDTLS tries to spawn processes
JDTLS requirement: Modern JDTLS requires Java 21+ as minimum runtime

Changes

runtime_dependencies.json:
- Updated all platforms from vscode-java v1.23.0 to v1.40.0
- Changed JRE paths from Java 17 (17.0.8.1-*) to Java 21 (21.0.6-*)
- Updated lombok from v1.18.30 to v1.18.36
- Updated JDTLS launcher from 1.6.500.v20230717-2134 to 1.6.1000.v20250131-0606
- Added proper linux-arm64 support with config_linux_arm configuration
eclipse_jdtls.py:
- Updated JavaSE runtime name from JavaSE-17 to JavaSE-21
initialize_params.json:
- Updated default runtime template from Java 17 to Java 21

Testing

Tested on macOS ARM64 (Apple Silicon M1):

Before: Got 0 completions
After: Got 2 completions (including newServerNode, class)

The osx-arm64 configuration was incorrectly downloading the x64 binary (java@darwin-x64) and using x86_64 JRE paths instead of the proper ARM64 binary and aarch64 paths. Changes: - Download darwin-arm64 VSIX instead of darwin-x64 - Use macosx-aarch64 JRE paths instead of macosx-x86_64 This fixes JDTLS on Apple Silicon Macs (M1/M2/M3).

This commit upgrades Eclipse JDTLS dependencies to fix macOS ARM64 completions and bring modern Java support: Changes: - Update vscode-java from v1.23.0 to v1.40.0 for all platforms - Upgrade bundled JRE from Java 17 to Java 21.0.6 - Update JDTLS launcher to v1.6.1000.v20250131-0606 - Update lombok to v1.18.36 - Fix osx-arm64 to use correct darwin-arm64 binary and aarch64 paths - Add linux-arm64 support with config_linux_arm configuration Why Java 21 is required: - Eclipse JDTLS v1.40+ requires Java 21 as minimum runtime - The bundled JustJ JRE (Java 17) has broken jspawnhelper on macOS ARM64 - Java 21 from vscode-java has proper ARM64 process spawning support This fixes the macOS ARM64 issue where completions returned 0 items due to posix_spawn failures in the bundled Java 17 JRE. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The `parent.children(recursive=True)` call can throw `psutil.NoSuchProcess` if child processes exit during iteration. This was causing TypeScript LSP tests to fail on macOS with "process PID not found" errors during server shutdown. Wrap the children iteration loop in a try-except to handle the race condition where child processes may exit between the time they're enumerated and when we try to signal them. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

gruckion · 2025-12-13T22:48:11Z

@microsoft-github-policy-service agree [company="Gruckion Limited"]

Copilot

Pull request overview

This PR upgrades Eclipse JDTLS from vscode-java v1.23.0 (Java 17) to v1.40.0 (Java 21) to fix macOS ARM64 completion issues caused by downloading the wrong binary and using an incompatible JRE version.

Changes:

Upgraded vscode-java from v1.23.0 to v1.40.0 with Java 21.0.6 for all platforms
Fixed osx-arm64 configuration to download correct darwin-arm64 binary instead of darwin-x64
Added linux-arm64 support with proper config_linux_arm configuration
Updated lombok (1.18.30→1.18.36) and JDTLS launcher versions

Reviewed changes

Copilot reviewed 13 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`eclipse_jdtls/runtime_dependencies.json`	Updated all platform URLs to v1.40.0, Java 21 paths, and fixed osx-arm64 binary
`eclipse_jdtls/initialize_params.json`	Updated default runtime from JavaSE-17 to JavaSE-21
`eclipse_jdtls/eclipse_jdtls.py`	Updated runtime name assertions from JavaSE-17 to JavaSE-21
`server.py`	Added exception handling for race condition in process cleanup (unrelated bug fix)
Multiple JSON files	Formatting improvements (whitespace normalization)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T04:33:30Z

+                for child in parent.children(recursive=True):
+                    try:
+                        getattr(child, signal_method)()
+                    except (psutil.NoSuchProcess, psutil.AccessDenied, Exception):


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-02-05T04:33:30Z

+                        getattr(child, signal_method)()
+                    except (psutil.NoSuchProcess, psutil.AccessDenied, Exception):
+                        pass
+            except (psutil.NoSuchProcess, psutil.AccessDenied, Exception):


'except' clause does nothing but pass and there is no explanatory comment.

LakshyAAAgrawal · 2026-04-10T02:04:48Z

Thank you for this work, @gruckion! We're closing this in favor of #126 by @vergenzt which targets a newer vscode-java version (v1.46.0 vs v1.40.0) and also upgrades Gradle to 7.6.6.

Your PR caught an important issue that #126 missed: the JavaSE-17 → JavaSE-21 update in eclipse_jdtls.py and initialize_params.json. We're incorporating that fix. You'll be credited as a contributor on the merged commit.

The server.py race condition fix from your PR was already merged separately in #133.

@gruckion

The JRE bundled with vscode-java was upgraded from Java 17 to Java 21 in microsoft#126, but the JavaSE runtime name references in eclipse_jdtls.py and initialize_params.json were not updated. This causes an assertion failure at runtime because the assert expects JavaSE-17 in the config but the JSON now specifies Java 21 paths. Caught by @gruckion in microsoft#128.

@vergenzt

Upgrade Eclipse JDTLS runtime dependencies: - vscode-java: v1.23.0 -> v1.46.0 - Bundled JRE: Java 17 -> Java 21 (JavaSE-17 -> JavaSE-21) - Gradle: 7.3.3 -> 7.6.6 (with templated URL) - Lombok: 1.18.30 -> 1.18.39 - IntelliCode: 1.2.30 -> 1.3.2 - Equinox launcher: 1.6.500 -> 1.7.0 - Fix osx-arm64: was incorrectly downloading x64 binary Based on work by @vergenzt (microsoft#126) and @gruckion (microsoft#128). Closes microsoft#126, closes microsoft#128. Contributed-by: Tim Vergenz <vergenzt@users.noreply.github.com> Contributed-by: Stephen Rayner <contact@gruckion.com>

gruckion and others added 2 commits December 11, 2025 20:22

gruckion changed the title ~~fix(jdtls): use correct ARM64 binary and paths for osx-arm64~~ feat(jdtls): upgrade to vscode-java v1.40.0 with Java 21 for macOS ARM64 fix Dec 11, 2025

LakshyAAAgrawal requested a review from Copilot February 5, 2026 04:30

Copilot started reviewing on behalf of LakshyAAAgrawal February 5, 2026 04:30 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

LakshyAAAgrawal closed this Apr 10, 2026

LakshyAAAgrawal mentioned this pull request Apr 10, 2026

Update runtime dependencies for Java Language Server #126

Closed

LakshyAAAgrawal mentioned this pull request Apr 10, 2026

Update JavaSE-17 references to JavaSE-21 for JDTLS JRE upgrade #138

Closed

LakshyAAAgrawal mentioned this pull request Apr 10, 2026

Upgrade JDTLS to vscode-java v1.46.0 with Java 21, Gradle 7.6.6 #139

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(jdtls): upgrade to vscode-java v1.40.0 with Java 21 for macOS ARM64 fix#128

feat(jdtls): upgrade to vscode-java v1.40.0 with Java 21 for macOS ARM64 fix#128
gruckion wants to merge 3 commits intomicrosoft:mainfrom
gruckion:fix/osx-arm64-runtime-dependencies

gruckion commented Dec 11, 2025 •

edited

Loading

Uh oh!

gruckion commented Dec 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

LakshyAAAgrawal commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gruckion commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Root Causes

Changes

Testing

Related

Uh oh!

gruckion commented Dec 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

LakshyAAAgrawal commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gruckion commented Dec 11, 2025 •

edited

Loading