Onboard Azure Advisor MCP Tool - Apply Advisor Recommendations by ankiga-MSFT · Pull Request #2686 · microsoft/mcp

ankiga-MSFT · 2026-05-20T12:16:21Z

What does this PR do?

Add Azure Advisor MCP Tool - Apply Advisor Recommendations

GitHub issue number?

2685

Pre-merge Checklist

…://github.com/ankiga-MSFT/msft-advisor-mcp into ankiga-MSFT/advisor-mcp-apply-recommendations

…mmendations

Copilot

Pull request overview

This PR onboards an Azure Advisor MCP tool command (azmcp advisor recommendation apply) that returns embedded “apply recommendation” rule definitions for a set of Azure resource types, along with unit tests and server/docs registration.

Changes:

Added RecommendationApplyCommand (+ options + JSON source-gen support) to return embedded rule JSON by --resource.
Added embedded Resources/*.json rule definitions for multiple Azure resource types.
Wired the tool into Azure MCP Server metadata/docs and added unit tests for the new command.

Invoking Livetests

Copilot submitted PRs are not trustworthy by default. Users with write access to the repo need to validate the contents of this PR before leaving a comment with the text /azp run mcp - pullrequest - live. This will trigger the necessary livetest workflows to complete required validation.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
tools/Azure.Mcp.Tools.Advisor/src/Commands/Recommendation/RecommendationApplyCommand.cs	New “apply” command that validates `--resource`, loads embedded JSON, and caches results.
tools/Azure.Mcp.Tools.Advisor/src/Options/Recommendation/RecommendationApplyOptions.cs	Options POCO for the apply command.
tools/Azure.Mcp.Tools.Advisor/src/Options/Recommendation/RecommendationApplyOptionDefinitions.cs	Defines the `--resource` option and help text.
tools/Azure.Mcp.Tools.Advisor/src/Commands/AdvisorJsonContext.cs	Adds source-gen support for `List<string>` responses.
tools/Azure.Mcp.Tools.Advisor/src/AdvisorSetup.cs	Registers the new command in DI and command group.
tools/Azure.Mcp.Tools.Advisor/tests/Azure.Mcp.Tools.Advisor.Tests/Recommendation/RecommendationApplyCommandTests.cs	Unit tests covering metadata, validation, deserialization, and caching behavior.
tools/Azure.Mcp.Tools.Advisor/src/Resources/aad_domainservices.json	New embedded rule definitions for Entra Domain Services.
tools/Azure.Mcp.Tools.Advisor/src/Resources/apimanagement_service.json	New embedded rule definitions for API Management.
tools/Azure.Mcp.Tools.Advisor/src/Resources/cognitiveservices_accounts.json	New embedded rule definitions for Cognitive Services accounts.
tools/Azure.Mcp.Tools.Advisor/src/Resources/compute_virtualmachines.json	New embedded rule definitions for VMs.
tools/Azure.Mcp.Tools.Advisor/src/Resources/compute_virtualmachinescalesets.json	New embedded rule definitions for VM scale sets.
tools/Azure.Mcp.Tools.Advisor/src/Resources/containerregistry_registries.json	New embedded rule definitions for ACR.
tools/Azure.Mcp.Tools.Advisor/src/Resources/containerservice_managedclusters.json	New embedded rule definitions for AKS clusters.
tools/Azure.Mcp.Tools.Advisor/src/Resources/dbforpostgresql_flexibleservers.json	New embedded rule definitions for PostgreSQL flexible servers.
tools/Azure.Mcp.Tools.Advisor/src/Resources/documentdb_databaseaccounts.json	New embedded rule definitions for Cosmos DB accounts.
tools/Azure.Mcp.Tools.Advisor/src/Resources/keyvault_vaults.json	New embedded rule definitions for Key Vault.
tools/Azure.Mcp.Tools.Advisor/src/Resources/kubernetes_connectedclusters.json	New embedded rule definitions for Arc connected clusters.
tools/Azure.Mcp.Tools.Advisor/src/Resources/kubernetesconfiguration_extensions.json	New embedded rule definitions for Kubernetes extensions.
tools/Azure.Mcp.Tools.Advisor/src/Resources/netapp_volumes.json	New embedded rule definitions for NetApp volumes.
tools/Azure.Mcp.Tools.Advisor/src/Resources/network_applicationgatewaywebapplicationfirewallpolicies.json	New embedded rule definitions for App Gateway WAF policies.
tools/Azure.Mcp.Tools.Advisor/src/Resources/network_expressrouteports.json	New embedded rule definitions for ExpressRoute ports.
tools/Azure.Mcp.Tools.Advisor/src/Resources/network_frontdoorwebapplicationfirewallpolicies.json	New embedded rule definitions for Front Door WAF policies.
tools/Azure.Mcp.Tools.Advisor/src/Resources/sql_managedinstances.json	New embedded rule definitions for SQL managed instances.
tools/Azure.Mcp.Tools.Advisor/src/Resources/storage_storageaccounts.json	New embedded rule definitions for Storage accounts.
tools/Azure.Mcp.Tools.Advisor/src/Resources/web_serverfarms.json	New embedded rule definitions for App Service plans.
tools/Azure.Mcp.Tools.Advisor/src/Resources/web_staticsites.json	New embedded rule definitions for Static Web Apps.
servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json	Adds the new tool mapping (`advisor_recommendation_apply`) to the consolidated tool catalog.
servers/Azure.Mcp.Server/docs/azmcp-commands.md	Documents the new CLI command usage.

ankiga-MSFT · 2026-05-21T09:43:33Z

Results from Tool description evaluator run -

🎯 Filtering prompts to area: Advisor
📝 Using default prompts file (e2eTestPrompts.md) for Azure.Mcp.Server
💾 Saved prompts to prompts.json
🧪 Tested 5 prompts:
📊 Top choice: 100.0%
💪 Very High confidence (≥0.8): 0.0%
🎯 High confidence (≥0.7): 0.0%
✅ Good confidence (≥0.6): 100.0%
👍 Fair confidence (≥0.5): 100.0%
👌 Acceptable confidence (≥0.4): 100.0%
⭐ Top + acceptable confidence (≥0.4): 100.0%
🎯 Tool selection analysis completed
📊 Results written to: D:\msft-advisor-mcp\eng\tools\ToolDescriptionEvaluator\results.md
⏱️ Total execution time: 14.0659464s

Expected Tool: advisor_recommendation_apply
Prompt: Apply Advisor recommendations to this ARM template

Results

Rank	Score	Tool	Status
1	0.632157	`advisor_recommendation_apply`	✅ EXPECTED
2	0.523744	`advisor_recommendation_list`	❌
3	0.459641	`azureterraformbestpractices_get`	❌
4	0.435818	`deploy_pipeline_guidance_get`	❌
5	0.429113	`get_azure_bestpractices_get`	❌

Expected Tool: advisor_recommendation_apply
Prompt: Apply Advisor recommendations to this Terraform file for Storage Account

Results

Rank	Score	Tool	Status
1	0.617697	`advisor_recommendation_apply`	✅ EXPECTED
2	0.508354	`azureterraformbestpractices_get`	❌
3	0.504128	`fileshares_rec`	❌
4	0.473977	`advisor_recommendation_list`	❌
5	0.413549	`azurebackup_vault_update`	❌

ankiga-MSFT · 2026-05-21T09:44:06Z

Results from Tool description evaluator run -

🎯 Filtering prompts to area: Advisor
📝 Using default prompts file (e2eTestPrompts.md) for Azure.Mcp.Server
💾 Saved prompts to prompts.json
🧪 Tested 5 prompts:
📊 Top choice: 100.0%
💪 Very High confidence (≥0.8): 0.0%
🎯 High confidence (≥0.7): 0.0%
✅ Good confidence (≥0.6): 100.0%
👍 Fair confidence (≥0.5): 100.0%
👌 Acceptable confidence (≥0.4): 100.0%
⭐ Top + acceptable confidence (≥0.4): 100.0%
🎯 Tool selection analysis completed
📊 Results written to: D:\msft-advisor-mcp\eng\tools\ToolDescriptionEvaluator\results.md
⏱️ Total execution time: 14.0659464s

Expected Tool: advisor_recommendation_apply
Prompt: Apply Advisor recommendations to this ARM template

Results

Rank	Score	Tool	Status
1	0.632157	`advisor_recommendation_apply`	✅ EXPECTED
2	0.523744	`advisor_recommendation_list`	❌
3	0.459641	`azureterraformbestpractices_get`	❌
4	0.435818	`deploy_pipeline_guidance_get`	❌
5	0.429113	`get_azure_bestpractices_get`	❌

Expected Tool: advisor_recommendation_apply
Prompt: Apply Advisor recommendations to this Terraform file for Storage Account

Results

Rank	Score	Tool	Status
1	0.617697	`advisor_recommendation_apply`	✅ EXPECTED
2	0.508354	`azureterraformbestpractices_get`	❌
3	0.504128	`fileshares_rec`	❌
4	0.473977	`advisor_recommendation_list`	❌
5	0.413549	`azurebackup_vault_update`	❌

alzimmermsft · 2026-05-22T13:31:05Z

+    public override string Name => "apply";
+
+    public override string Description =>
+        @"This tool applies advisor recommendations to create or modify IaaC files (like ARM, Terraform) for Azure resources. It returns the rules that can be applied to the IaaC file.";


The name and description here are a bit confusing as this tool doesn't actually apply the recommendation but returns the recommendations that are applicable to the resource.

alzimmermsft · 2026-05-22T13:32:04Z

+            if (string.IsNullOrEmpty(options.Resource))
+            {
+                context.Response.Status = HttpStatusCode.BadRequest;
+                context.Response.Message = "Resource parameter is required.";
+                return Task.FromResult(context.Response);
+            }


This isn't needed as this is already handled in RegisterOptions's validator

alzimmermsft · 2026-05-22T13:33:43Z

+        if (string.IsNullOrEmpty(resourceFileName))
+        {
+            throw new ArgumentException("Resource file name cannot be null or empty.", nameof(resourceFileName));
+        }


This case is impossible given the guards applied before calling into this method, we could remove this

alzimmermsft · 2026-05-22T13:34:58Z

+            var recommendationApplyRules = GetAdvisorRecommendationRules(resourceFileName);
+
+            context.Response.Status = HttpStatusCode.OK;
+            context.Response.Results = ResponseResult.Create([recommendationApplyRules], AdvisorJsonContext.Default.ListString);


Based on how GetAdvisorRecommendationRules works, recommendationApplyRules could be null. Should check for that here so we don't return [null] and instead when it is null return []

alzimmermsft · 2026-05-22T13:41:54Z

@@ -0,0 +1,86 @@
+{
+  "rules": [


Will these JSON files ever have other top-level properties in them other than rules? If not, we might want to make some slight modifications to the tool to make the tool response clearer. Right now, it's something like:

[ { "rules": [ <one or more rules> ] } ]

We could remove the nesting here and make it:

{ "rules": [ <one or more rules> ] }

Also, if rules follows a common shape we probably want to read these JSON files as JsonElement so they can be interacted with more meaningfully in the MCP tool if they are expected to change over time.

ankiga-MSFT and others added 14 commits February 3, 2026 21:19

Adding changes for Advisor Apply Recommendations - MCP tool

9c0b1d9

Advisor - Apply Recommendations

d6088ca

Merging and Resolving Conflicts

b850ea4

Reference CSV

436d77a

Merge branch 'ankiga-MSFT/advisor-mcp-apply-recommendations' of https…

acc009e

…://github.com/ankiga-MSFT/msft-advisor-mcp into ankiga-MSFT/advisor-mcp-apply-recommendations

Scoping recommendations based on Build Scope

2e9fa8b

Merge branch 'ankiga-MSFT/advisor-mcp-apply-recommendations' of https…

6cf9730

…://github.com/ankiga-MSFT/msft-advisor-mcp into ankiga-MSFT/advisor-mcp-apply-recommendations

Adding support for Terraform templates

7647b6e

Modifying the resource type list based on available recommendations

146c28a

Removing helper files

65bb859

Cleanup for unsupported scenario (Arch Diagrams)

70bf428

Merge branch 'microsoft:main' into ankiga-MSFT/advisor-mcp-apply-reco…

458b8dc

…mmendations

Build fixes after syncing latest changes

4f28678

Unit Tests for Apply Recommendation

2a02f5e

Copilot AI review requested due to automatic review settings May 20, 2026 12:16

ankiga-MSFT requested review from a team as code owners May 20, 2026 12:16

ankiga-MSFT requested review from JasonYeMSFT, g2vinay, hallipr, joshfree, saikoumudi, tmeschter and vukelich May 20, 2026 12:16

github-project-automation Bot added this to Azure MCP Server May 20, 2026

github-project-automation Bot moved this to Untriaged in Azure MCP Server May 20, 2026

github-actions Bot added the tools-Advisor label May 20, 2026

Copilot started reviewing on behalf of ankiga-MSFT May 20, 2026 12:19 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Adding CHANGELOG entry and E2E Test Prompt

23d2a3c

ankiga-MSFT added 2 commits May 20, 2026 18:09

Updating Azure MCP README file with Advisor Apply Recommendation tool

19d9a35

Fixing Copilot PR comments

b1ae757

alzimmermsft reviewed May 22, 2026

View reviewed changes

Conversation

ankiga-MSFT commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Invoking Livetests

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ankiga-MSFT commented May 21, 2026

Results

Results

Uh oh!

ankiga-MSFT commented May 21, 2026

Results

Results

Uh oh!

alzimmermsft May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alzimmermsft May 22, 2026

Choose a reason for hiding this comment

Uh oh!

alzimmermsft May 22, 2026

Choose a reason for hiding this comment

Uh oh!

alzimmermsft May 22, 2026

Choose a reason for hiding this comment

Uh oh!

alzimmermsft May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ankiga-MSFT commented May 20, 2026 •

edited

Loading

alzimmermsft May 22, 2026 •

edited

Loading