Remove overflow hidden from Button for Win32/Windows#4087
Merged
rurikoaraki merged 4 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
Conversation
rurikoaraki
changed the title
Saadnajmi
reviewed
Apr 14, 2026
Saadnajmi
approved these changes
Apr 14, 2026
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Merged
Saadnajmi
added a commit
to Saadnajmi/fluentui-react-native
that referenced
this pull request
Apr 16, 2026
The `pr` gate job is the only required status check for merging. Without `if: always()`, when any dependency job fails, the gate job gets skipped — and GitHub treats skipped as passing, allowing PRs with failing checks to be merged (e.g. microsoft#4087). This adds `if: always()` so the gate job always runs, and an explicit check that fails the job when any dependency failed or was cancelled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Turns out adding overflow hidden to all our Buttons is a perf problem for win32. So removing the property from win32 (and windows, in case they have a similar issue).
Verification
Tested the button in the win32 app. Corners look fine, double focus border also looks fine
Pull request checklist
This PR has considered (when applicable):