Remove experimental coroutines support#1521
Merged
DefaultRyan merged 6 commits intomicrosoft:masterfrom Mar 16, 2026
Merged
Conversation
Replace CppWinRTEnableLegacyCoroutines with CppWinRTEnableCpp17Coroutines Remove base_coroutine_system_winui.h, hasn't worked since PR 0.8 Support and test building with no coroutines Remove implementation selection machinery
sylveon
force-pushed
the
user/sylveon/await
branch
from
d9b0b09 to
494ac8f
Compare
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Add error message for missing coroutine support in C++.
DefaultRyan
reviewed
Mar 16, 2026
Member
DefaultRyan
left a comment
DefaultRyan
left a comment
There was a problem hiding this comment.
Had one question about the #ifdef removal, but it looks fine otherwise.
DefaultRyan
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace CppWinRTEnableLegacyCoroutines with CppWinRTEnableCpp17Coroutines
Remove base_coroutine_system_winui.h, hasn't worked since PR 0.8
Support and test building with no coroutines
Remove implementation selection machinery
Fixes #1520