refactor: environment variable names to follow a consistent naming convention#787
Draft
Pavan-Microsoft wants to merge 7 commits intodevfrom
Draft
refactor: environment variable names to follow a consistent naming convention#787Pavan-Microsoft wants to merge 7 commits intodevfrom
Pavan-Microsoft wants to merge 7 commits intodevfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request standardizes and clarifies environment variable and input naming conventions across multiple workflow files and the
.env.samplefile, primarily by renaming several Azure-related variables for consistency and readability. These changes affect deployment workflows and environment configuration, ensuring all references to Azure resource IDs, locations, and model names use unified and descriptive names.Key changes include:
Environment Variable and Input Renaming for Consistency:
.env.samplefor clarity, such as changingAZURE_EXISTING_AI_PROJECT_RESOURCE_IDtoAZURE_ENV_FOUNDRY_PROJECT_RIDandAZURE_ENV_LOG_ANALYTICS_WORKSPACE_IDtoAZURE_ENV_LOG_ANALYTICS_WORKSPACE_RID. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]AZURE_ENV_OPENAI_LOCATIONtoAZURE_ENV_AI_SERVICE_LOCATIONandIMAGE_TAGtoAZURE_ENV_IMAGE_TAGacross all relevant workflow files. [1] [2] [3] [4] [5] [6] [7] [8] [9].env.sample Variable Updates:
AZURE_OPENAI_GPT_MODELtoAZURE_ENV_GPT_MODEL_NAME,AZURE_OPENAI_IMAGE_MODELtoAZURE_ENV_IMAGE_MODEL_NAME, andAZURE_OPENAI_API_VERSIONtoAZURE_ENV_OPENAI_API_VERSION. [1] [2]Workflow Logic and Output Adjustments:
These changes improve maintainability and reduce confusion by enforcing a clear and consistent naming scheme for all Azure-related configuration and workflow variables.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation