Remove synthetic/structured data generation from diskann-providers#904
Draft
Remove synthetic/structured data generation from diskann-providers#904
Conversation
- Remove generate_structured_data.rs: grid generation now uses diskann::graph::test::synthetic::Grid from the core diskann crate - Remove generate_synthetic_labels_utils.rs: the binary now uses the implementation already in diskann-tools - Update all consumers (diskann_async tests, debug_provider tests, caching example tests) to use Grid enum for data/neighbors - Update generate_synthetic_labels binary to use diskann-tools' generate_labels with FileStorageProvider Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/8b939579-a0bf-4896-b561-0c6e819be001 Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove synthetic data generation from diskann-providers
Remove synthetic/structured data generation from diskann-providers
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diskann-providerscontained grid point generation and synthetic label generation that already have replacements elsewhere:diskann::graph::test::synthetic::Gridanddiskann-tools::utils::generate_synthetic_labels_utilsrespectively.Deleted
diskann-providers/src/utils/generate_structured_data.rs— 1D/3D/4D grid vectors, adjacency lists, circle vectorsdiskann-providers/src/utils/generate_synthetic_labels_utils.rs— zipf/random/one_per_point label generationGrid data migration
All test consumers now use the
Gridenum fromdiskann::graph::test::synthetic:GenerateGridtrait impls now wrapGrid::data()/Grid::data_as()instead of the deleted functions. Addeddiskann = { features = ["testing"] }to dev-dependencies to access theGridtype.Synthetic labels migration
diskann-tools/src/bin/generate_synthetic_labels.rsnow usesdiskann_tools::utils::generate_labelswithFileStorageProviderinstead of the removeddiskann_providersversion.