Remove unused normalizing_util.rs from diskann-providers#902
Merged
harsha-simhadri merged 4 commits intomainfrom Apr 6, 2026
Merged
Remove unused normalizing_util.rs from diskann-providers#902harsha-simhadri merged 4 commits intomainfrom
normalizing_util.rs from diskann-providers#902harsha-simhadri merged 4 commits intomainfrom
Conversation
The normalizing_util module exported three functions (normalize_data_file, normalize_data_internal, normalize_data_internal_no_cblas) that had no callers anywhere in the codebase. Removing the module and its re-exports from utils/mod.rs as part of the diskann-providers cruft cleanup (#899). Closes #901 Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/96941172-bd7d-4bae-815d-af0d0fd8cf6b Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused normalizing utility
Remove unused Apr 6, 2026
normalizing_util.rs from diskann-providers
Contributor
There was a problem hiding this comment.
Pull request overview
Removes dead normalization utilities from diskann-providers::utils as part of the broader diskann-providers cleanup effort tracked in #899.
Changes:
- Deleted the unused
utils/normalizing_util.rsmodule (including its unit test). - Removed the
mod normalizing_utildeclaration andpub usere-exports fromutils/mod.rs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| diskann-providers/src/utils/normalizing_util.rs | Deleted unused normalization helpers and their test. |
| diskann-providers/src/utils/mod.rs | Removed module wiring and public re-exports for the deleted utilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 89.32% 90.47% +1.15%
==========================================
Files 445 444 -1
Lines 84095 83986 -109
==========================================
+ Hits 75116 75990 +874
+ Misses 8979 7996 -983
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
hildebrandmw
reviewed
Apr 6, 2026
Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/b46a05b5-8b1a-4082-a57a-cdb207203763 Co-authored-by: hildebrandmw <24898651+hildebrandmw@users.noreply.github.com>
hildebrandmw
approved these changes
Apr 6, 2026
harsha-simhadri
approved these changes
Apr 6, 2026
JordanMaples
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead code.
normalize_data_file,normalize_data_internal, andnormalize_data_internal_no_cblashave zero callers outside their own module.diskann-providers/src/utils/normalizing_util.rsmoddeclaration andpub usere-exports fromutils/mod.rsPart of
diskann-providerscruft cleanup (#899).