Skip to content

Remove unused normalizing_util.rs from diskann-providers#902

Merged
harsha-simhadri merged 4 commits intomainfrom
copilot/remove-normalizing-util
Apr 6, 2026
Merged

Remove unused normalizing_util.rs from diskann-providers#902
harsha-simhadri merged 4 commits intomainfrom
copilot/remove-normalizing-util

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 6, 2026

Dead code. normalize_data_file, normalize_data_internal, and normalize_data_internal_no_cblas have zero callers outside their own module.

  • Deleted diskann-providers/src/utils/normalizing_util.rs
  • Removed mod declaration and pub use re-exports from utils/mod.rs

Part of diskann-providers cruft cleanup (#899).

The normalizing_util module exported three functions (normalize_data_file,
normalize_data_internal, normalize_data_internal_no_cblas) that had no
callers anywhere in the codebase. Removing the module and its re-exports
from utils/mod.rs as part of the diskann-providers cruft cleanup (#899).

Closes #901

Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/96941172-bd7d-4bae-815d-af0d0fd8cf6b

Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unused normalizing utility Remove unused normalizing_util.rs from diskann-providers Apr 6, 2026
Copilot AI requested a review from harsha-simhadri April 6, 2026 20:18
@harsha-simhadri harsha-simhadri marked this pull request as ready for review April 6, 2026 20:24
@harsha-simhadri harsha-simhadri requested review from a team and Copilot April 6, 2026 20:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes dead normalization utilities from diskann-providers::utils as part of the broader diskann-providers cleanup effort tracked in #899.

Changes:

  • Deleted the unused utils/normalizing_util.rs module (including its unit test).
  • Removed the mod normalizing_util declaration and pub use re-exports from utils/mod.rs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
diskann-providers/src/utils/normalizing_util.rs Deleted unused normalization helpers and their test.
diskann-providers/src/utils/mod.rs Removed module wiring and public re-exports for the deleted utilities.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (55e157a) to head (0d9c311).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
+ Coverage   89.32%   90.47%   +1.15%     
==========================================
  Files         445      444       -1     
  Lines       84095    83986     -109     
==========================================
+ Hits        75116    75990     +874     
+ Misses       8979     7996     -983     
Flag Coverage Δ
miri 90.47% <ø> (+1.15%) ⬆️
unittests 90.43% <ø> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Agent-Logs-Url: https://github.com/microsoft/DiskANN/sessions/b46a05b5-8b1a-4082-a57a-cdb207203763

Co-authored-by: hildebrandmw <24898651+hildebrandmw@users.noreply.github.com>
@harsha-simhadri harsha-simhadri enabled auto-merge (squash) April 6, 2026 22:19
@harsha-simhadri harsha-simhadri merged commit de98ea6 into main Apr 6, 2026
23 checks passed
@harsha-simhadri harsha-simhadri deleted the copilot/remove-normalizing-util branch April 6, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

utils/normalizing_util.rs: Is this still used?

6 participants