Skip to content

Minor CMake code review#635

Open
walbourn wants to merge 5 commits intomainfrom
cmakecr
Open

Minor CMake code review#635
walbourn wants to merge 5 commits intomainfrom
cmakecr

Conversation

@walbourn
Copy link
Copy Markdown
Member

@walbourn walbourn commented May 6, 2026

  • use list(APPEND in more places
  • prevent odd message if FXC not found in path
  • Add SYSTEM to public interface include directory
  • CMake 3.21+ allows removal of JoinPaths.cmake helper.

@walbourn walbourn self-assigned this May 6, 2026
@walbourn walbourn added cmake Related to CMake build co_pilot Related to Co Pilot enablement for the project and removed co_pilot Related to Co Pilot enablement for the project labels May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadaOuf nadaOuf Awaiting requested review from nadaOuf

@Andrew-Farrier Andrew-Farrier Awaiting requested review from Andrew-Farrier

@scm-xbox scm-xbox Awaiting requested review from scm-xbox

@jonmartinms jonmartinms Awaiting requested review from jonmartinms

At least 1 approving review is required to merge this pull request.

Assignees

@walbourn walbourn

Labels

cmake Related to CMake build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@walbourn