Open
Conversation
A new package was added to `rcl_logging` called `rcl_logging_implementation`. It depends on `rcpputils`, which I wasn't able to get building. Therefore, we are skipping building that package using `COLCON_IGNORE`. https://github.com/ros2/rclc needs to be pinned to an older version until ros2/rcl#1269 is added in https://github.com/micro-ROS/rcl. This PR also fixes micro-ROS#251.
Also removed CI compatibility and mentions of ESP-IDF v4.4 as it's been declared EOL by Espressif. -
This was referenced Feb 27, 2026
Author
|
CI run: https://github.com/Amronos/micro_ros_espidf_component/actions/runs/22482739330 |
Author
|
@YanKE01, if possible, could you review/test this PR? |
YanKE01
reviewed
Mar 2, 2026
| git clone -b rolling https://github.com/ros2/rclc src/rclc; \ | ||
| cd src/rclc; \ | ||
| git reset --hard 2283a6d76c3f41a964d03610a3305166d8c2caaa; \ | ||
| cd ../..; \ |
Co-authored-by: @YanKE01
Amronos
force-pushed
the
support-esp-idf-v5.5
branch
from
6c5de44 to
d99c1e1
Compare
Author
|
Thanks a lot for the review! Most of your suggestions and questions have been addressed in my previous comments on this PR page and the PR's original description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes were mostly taken from #319 / #322, but ported to rolling. I will add support for ESP32-P4 in a separate PR.
This PR is part of the following stack of PRs, which should be merged in order: