Clarify std::string ownership in core APIs#1280
Open
bhack wants to merge 2 commits intometa-pytorch:mainfrom
Open
Clarify std::string ownership in core APIs#1280bhack wants to merge 2 commits intometa-pytorch:mainfrom
bhack wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1280
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
bhack
force-pushed
the
codex/string-vs-string-cleanup
branch
from
0fee817 to
f4db5e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1256
This makes the
std::stringvsstd::string_viewsplit explicit in the core C++ APIs.Policy:
std::stringfor owned or stored valuesstd::string_viewonly for borrow-only parsing and lookup helpersstd::stringat FFmpeg C-string boundaries