Add termperature reading from MCU to room server firmware#1989
Closed
Orum wants to merge 1 commit intomeshcore-dev:mainfrom
Closed
Add termperature reading from MCU to room server firmware#1989Orum wants to merge 1 commit intomeshcore-dev:mainfrom
Orum wants to merge 1 commit intomeshcore-dev:mainfrom
Conversation
weebl2000
approved these changes
Mar 10, 2026
Collaborator
|
Please change base branch to 'dev' |
Author
|
Is there a way to do that without submitting a whole new PR? I can't see how to change this one, at least on my end. |
Member
You'd need to check out the It looks like you've committed directly to your own main branch fork. You could create a new branch from your commit and then If you're using Visual Studio Code or some other IDE there should be a helper menu to rebase. |
Author
|
So it sounds like it's not possible to just switch this existing PR. I'll close it and open a new one on the dev branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was allegedly added back in v1.12.0 according to its release notes, but it wasn't actually there. This fixes that and puts the MCU temp in telemetry responses from room servers.