Skip to content

Add termperature reading from MCU to room server firmware#1989

Closed
Orum wants to merge 1 commit intomeshcore-dev:mainfrom
Orum:main
Closed

Add termperature reading from MCU to room server firmware#1989
Orum wants to merge 1 commit intomeshcore-dev:mainfrom
Orum:main

Conversation

@Orum
Copy link

@Orum Orum commented Mar 10, 2026

This was allegedly added back in v1.12.0 according to its release notes, but it wasn't actually there. This fixes that and puts the MCU temp in telemetry responses from room servers.

@ripplebiz
Copy link
Collaborator

Please change base branch to 'dev'

@Orum
Copy link
Author

Orum commented Mar 16, 2026

Is there a way to do that without submitting a whole new PR? I can't see how to change this one, at least on my end.

@liamcottle
Copy link
Member

Is there a way to do that without submitting a whole new PR? I can't see how to change this one, at least on my end.

You'd need to check out the dev branch in your code editor, and make the commit there.

It looks like you've committed directly to your own main branch fork.

You could create a new branch from your commit and then rebase that branch onto dev in your IDE or via Git CLI.

If you're using Visual Studio Code or some other IDE there should be a helper menu to rebase.

@Orum
Copy link
Author

Orum commented Mar 16, 2026

So it sounds like it's not possible to just switch this existing PR. I'll close it and open a new one on the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants