Open
Conversation
|
Looks OKayish! Need to add documentation so everyone, who is adding/writing Meshcore code can easy find function named millis_passed() without looking/listing tons of headers. |
3a50df3 to
79578fb
Compare
Contributor
Author
Added a doxygen comment, do we want docs in more places? |
|
Is doxygen documentation generated automatically? That would be nice. Btw, problem, theory and fix on millis() 49 day rollover problem is here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this one would actually occur in the field. But @ripplebiz managed to point me in the right direction by setting clock 5 mins prior to the 49 day wraparound.
First half of the 49 day wrap period the check works, but the second half it didn't because of the wraparound bug.
Good to have it fixed for any future changes that might impact it.