feat(ApiWeb, config): add StopEventsController and resources behind feature flags#987
Open
runkelcorey wants to merge 4 commits intomasterfrom
Open
feat(ApiWeb, config): add StopEventsController and resources behind feature flags#987runkelcorey wants to merge 4 commits intomasterfrom
runkelcorey wants to merge 4 commits intomasterfrom
Conversation
runkelcorey
commented
Mar 27, 2026
Contributor
Author
There was a problem hiding this comment.
just wrapping this in a conditional; otherwise, no change
runkelcorey
commented
Mar 27, 2026
Contributor
Author
There was a problem hiding this comment.
just wrapping this in a conditional; otherwise, no change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 📸↩︎ construct database query (ApiWeb.StopEventController + ApiWeb.StopEventView.location + router)
ApiWeb. These are true in dev and test but false in prod and by default. These allow the endpoint to be hidden and prevent the relevant modules inApiWebfrom being compiled (or invoked) in productionStopEventControllerHow were these changes validated?
mix phx.serverlocally withstop_events_routetrueandfalse, observing that the paths were not shown on the docs when the flag was false and were shown when the flag was trueWhat questions should reviewers consider?