Add inline_br option for linebreaks in inline elements#258
Open
TytoCapensis wants to merge 1 commit intomatthewwithanm:developfrom
Open
Add inline_br option for linebreaks in inline elements#258TytoCapensis wants to merge 1 commit intomatthewwithanm:developfrom
TytoCapensis wants to merge 1 commit intomatthewwithanm:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some HTML tables (and generally, other inline elements) may use
<br>in table cells. For example:Currently, line breaks with
<br>in inline elements are replaced by spaces. The table above is converted to this by markdownify:This is acceptable, but it may lead to confusion in some cases.
There is no official Markdown way to have line-breaks inside cells, but the de-facto standard is to use
<br>to manage this:(Note that this also works in GitHub's Markdown)
This pull request adds a
inline_br/--inline-broption to keep all inline<br>tags. (This option is disabled by default to not disrupt existing behaviors)All tests are passing. If I force
inline_bron all tests, 2 are failing (because of a<br>conversion, which is expected). Feel free to suggest how this could be integrated in tests!