Add Account Struct#94
Conversation
| } | ||
|
|
||
| impl LogosAccount { | ||
| pub fn new_test(explicit_id: impl Into<String>) -> Self { |
There was a problem hiding this comment.
Better use new, with comment on when to use it and the plan to move forward.
There was a problem hiding this comment.
New would imply that this is a constructor for a production Account. This is specifically to be used in test scenarios or clients prior to the blockchain integration. Calling it the primary constructor seems like it would be inaccurate and lead to breaking changes.
There was a problem hiding this comment.
No description provided.
There was a problem hiding this comment.
Following up here, incase there is any confusion: given this function will be removed entirely soon - I thought including "test" in the name would be a warning for everyone - I've added a comment to reflect that as well.
I don't have any blockers if anyone feels it needs to be changed - But my focus is entirely on decomposing #92 to make it easier to review.
| } | ||
|
|
||
| impl Signer for LogosAccount { | ||
| // TODO: (P2) Remove OpenMLS references |
There was a problem hiding this comment.
I'm confusing what this comment means.
Co-authored-by: osmaczko <33099791+osmaczko@users.noreply.github.com>
jazzz
force-pushed
the
jazzz/mls/account
branch
from
f8246ba to
9604405
Compare
3 participants
This PR Adds a LogosAccount struct to prepare for MLS and PQ identity.
This is added separately to reduce the noise in #92
Notes
Accountin the future.