Open
Conversation
Add Lambda resource matching in the proxy handler (FunctionName/ARN-based) and comprehensive integration tests covering basic proxying, read-only mode, and resource name pattern matching. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
whummer
force-pushed
the
add-lambda-proxy-tests
branch
from
1204f7b to
976911c
Compare
| "PartiQLSelect", | ||
| }: | ||
| return True | ||
| if context.service.service_name == "lambda" and operation_name in { |
Contributor
There was a problem hiding this comment.
I'm not quite sure if we should consider the invoking of lambdas as a "read" operation.
Running a lambda can have many side-effects. I wouldn't expect the lambda to be called when I use read-only mode. Especially in the era of AI-agents, this can be very problematic for a user that may have thought that they give read-only access to the proxy.
Could we introduce some other mode specifically for cases like this? (like execute or invoke?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Lambda resource matching in the proxy handler (FunctionName/ARN-based) and comprehensive integration tests covering basic proxying, read-only mode, and resource name pattern matching.