[Wayland] Add support for pointer-warp-v1 protocol#795
Open
Sunderland93 wants to merge 4 commits intolinuxmint:masterfrom
Open
[Wayland] Add support for pointer-warp-v1 protocol#795Sunderland93 wants to merge 4 commits intolinuxmint:masterfrom
Sunderland93 wants to merge 4 commits intolinuxmint:masterfrom
Conversation
Only allow this while an implicit grab is held, so that it is not assumed to be a generic warping mechanism.
Sunderland93
force-pushed
the
pointer_warp
branch
from
7a42499 to
9b51e95
Compare
mtwebster
reviewed
Mar 5, 2026
Comment on lines
+70
to
+71
| x < 0 || x > clutter_actor_get_width (CLUTTER_ACTOR (surface_actor)) || | ||
| y < 0 || y > clutter_actor_get_height (CLUTTER_ACTOR (surface_actor))) |
Member
There was a problem hiding this comment.
should use coords.x, coords.y here instead of x, y?
Contributor
Author
There was a problem hiding this comment.
Using x and y is correct because the bounds check must happen in the surface-local coordinate space, before any transformation is applied.
Member
There was a problem hiding this comment.
I mean, you can't can't compare wl_fixed_t this way, you have to extract the value first (with wl_fixed_to_double()) - you could use the values you initialized coords to since this is before the transform below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only allow this while an implicit grab is held, so that it is not assumed to be a generic warping mechanism.