fix(keyboard): apply numlock state on startup and after resume#459
Open
H09-0 wants to merge 2 commits into
Open
fix(keyboard): apply numlock state on startup and after resume#459H09-0 wants to merge 2 commits into
H09-0 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The numlock LED state is not restored after resuming from suspend. While there are GSettings keys to store and remember the numlock state (
remember-numlock-state,numlock-state), no code incinnamon-settings-daemonactually reads or applies them.Changes
remember-numlock-stateandnumlock-statefrom GSettings and applies the LED state viaXkbLockModifiers. No-ops on Wayland, whenremember-numlock-stateis false, or when the stored state isunknown.org.freedesktop.login1.Managerand listens forPrepareForSleep(false)to re-apply the numlock state after resume.apply_numlock()is called fromapply_all_settings()so the stored state is applied when the keyboard plugin starts.A minimal, focused fix: no new schema keys, no dynamic state tracking, no key listeners.