Add support for firewall rules version and fingerprint#656
Open
zliang-akamai wants to merge 1 commit intodevfrom
Open
Add support for firewall rules version and fingerprint#656zliang-akamai wants to merge 1 commit intodevfrom
zliang-akamai wants to merge 1 commit intodevfrom
Conversation
zliang-akamai
requested review from
dawiddzhafarov and
jriddle-linode
and removed request for
a team
zliang-akamai
force-pushed
the
zhiwei/firewall-rules-version-fingerprint
branch
from
5b15754 to
66ea575
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds test and fixture coverage for the new version and fingerprint fields returned as part of Firewall rules, ensuring these fields are available to SDK consumers via the existing rules mapping behavior.
Changes:
- Extend unit tests to assert
Firewall.rules.versionandFirewall.rules.fingerprint. - Extend firewall integration tests to validate
version/fingerprintpresence and basic types/constraints. - Update firewall rules fixtures to include
versionandfingerprintfields in mocked API responses.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/unit/objects/firewall_test.py | Adds assertions that unit-loaded firewall rules expose version and fingerprint. |
| test/integration/models/firewall/test_firewall.py | Adds integration assertions validating version/fingerprint are present and well-formed after get/update. |
| test/fixtures/networking_firewalls_123_rules.json | Updates mocked /networking/firewalls/123/rules response to include version/fingerprint. |
| test/fixtures/networking_firewalls_123.json | Updates mocked firewall resource fixture to include version/fingerprint inside rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support for firewall rules version and fingerprint
✔️ How to Test