-
Notifications
You must be signed in to change notification settings - Fork 444
RBF splice funding transactions #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkczyz
wants to merge
22
commits into
lightningdevkit:main
Choose a base branch
from
jkczyz:2026-02-splicing-rbf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,603
−187
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
953ac60
Accept tx_init_rbf for pending splice transactions
jkczyz 7384231
f - Also check sent_funding_txid in validate_tx_init_rbf
jkczyz dcf1d86
f - Remove redundant holder_is_quiescence_initiator field
jkczyz 7c740df
f - Remove unnecessary debug_assert in internal_tx_init_rbf
jkczyz 77071bb
f - DRY up splice_init and tx_init_rbf acceptor paths
jkczyz dedba7b
Allow multiple RBF splice candidates in channel monitor
jkczyz fca092c
Add rbf_channel API for initiating splice RBF
jkczyz 0133f7d
f - Also check received_funding_txid in can_initiate_rbf
jkczyz 90ecea2
Send tx_init_rbf instead of splice_init when a splice is pending
jkczyz b612aa4
Handle tx_ack_rbf on the initiator side
jkczyz 99b2c19
f - Extract awaiting_ack_context and begin_funding_negotiation helpers
jkczyz 340b63a
f - Replace begin_funding_negotiation with FundingNegotiation::for_in…
jkczyz c97e2e0
f - Use specific expect messages in tx_ack_rbf and splice_ack
jkczyz d7a7d51
f - Add test_splice_rbf_not_quiescence_initiator test
jkczyz 9ab6afa
f - Remove unnecessary debug_assert in internal_tx_ack_rbf
jkczyz 3161a7f
Allow acceptor contribution to RBF splice via tx_init_rbf
jkczyz da11547
Preserve our funding contribution across counterparty RBF attempts
jkczyz 088fe24
Consider prior contributions when filtering unique inputs/outputs
jkczyz 86be616
Filter prior contributions from SpliceFundingFailed events
jkczyz 759da6a
Handle FeeRateAdjustmentError variants in splice_init acceptor path
jkczyz 0df4730
f - Simplify FeeRateAdjustmentError match by moving suffixes into Dis…
jkczyz 9c91289
Handle FeeRateAdjustmentError variants in tx_init_rbf acceptor path
jkczyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made sure a dual-funded channel became locked prior to allowing a splice to happen.