Add e2e config startup tests#142
Open
benthecarman wants to merge 2 commits intolightningdevkit:mainfrom
Open
Conversation
Add electrsd and rand dependencies to run real electrs processes in tests. Tests now randomly pick between bitcoind RPC, electrum, and esplora as the chain source for broader coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test server startup with various config settings: optional fields, log levels, TLS hosts, LSPS2 variations, and bitcoind RPC with localhost hostname. Add negative tests for invalid configs ensuring proper error messages. Dedicated chain source tests verify each backend explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I've assigned @jkczyz as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #128 / #113
Refactor the e2e test infrastructure to support pluggable chain source. Existing tests now randomly pick between bitcoind RPC, electrum, and esplora backends for broader coverage. Also add config test suite that verifies server startup with various config combinations (to prevent things like #129) and validates errors for invalid configs.