Add ability to open channel / splice with all on-chain funds#788
Merged
tnull merged 4 commits intolightningdevkit:mainfrom Mar 2, 2026
Merged
Add ability to open channel / splice with all on-chain funds#788tnull merged 4 commits intolightningdevkit:mainfrom
tnull merged 4 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
tnull
reviewed
Feb 16, 2026
benthecarman
force-pushed
the
open-channel-all
branch
2 times, most recently
from
9e1c88d to
86e2792
Compare
Contributor
Author
|
Responded to review. Also added commit for splicing in with all funds |
benthecarman
changed the title
tnull
previously approved these changes
Feb 24, 2026
…send DRY up the repeated pattern of building a temporary drain transaction to estimate fees. Both send_all_to_address (AllRetainingReserve) and the upcoming open_channel_with_all / splice_in_with_all need this logic, so extract it into shared helpers.
Adds open_channel_with_all which uses get_max_drain_amount to determine the largest funding amount after accounting for on-chain fees and anchor reserves
Adds splice_in_with_all which uses get_max_drain_amount with a shared input to determine the largest splice-in amount after accounting for on-chain fees and anchor reserves.
DRY up the anchor reserve calculation that was duplicated between Node::new_channel_anchor_reserve_sats and the OpenChannelRequest handler in event.rs.
benthecarman
force-pushed
the
open-channel-all
branch
from
86e2792 to
56730e9
Compare
tnull
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #777
Uses the same fee estimation logic that
send_all_to_addressuses which can be hack but it works today.Tests generated with claude.