Handle a bunch of potential crashes / memory leaks#97
Open
Conversation
Avoids allocating a new client on every HTTP request.
Fixes potential panics in drupal, elm, pub, cpan, pypi_rss, hackage, packagist, and cocoapods ingestors when upstream feeds change format. Each bad item is now logged as a warning and skipped rather than crashing the process.
The channel was created inside run() so Publish() could send on a nil channel if called before the goroutine was scheduled. Move the make() into NewPipeline() to guarantee it exists before any caller can use it.
gofeed returns *time.Time for PublishedParsed/UpdatedParsed; they are nil when a feed entry omits the date field. Dereference without a nil check panics. Adds guards in elm, cpan, hackage, packagist, pub, cocoapods, and pypi_rss (three call sites).
Without recover(), a panic in any ingestor kills the whole process. The deferred recover logs the panic and lets the goroutine exit cleanly; the cron scheduler will fire ingestAndPublish again on the next tick.
- randomHex: log.WithFields was missing the terminal .Error() call so rand.Reader failures were silently swallowed - LPush: capture and log the error return so Redis failures are visible rather than silently dropping jobs
tiegz
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.