Skip to content

Update Open API Client SDKs to version 3.13.5#979

Open
github-actions[bot] wants to merge 1 commit intomainfrom
open-api-generator
Open

Update Open API Client SDKs to version 3.13.5#979
github-actions[bot] wants to merge 1 commit intomainfrom
open-api-generator

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Feb 3, 2026

Generated OpenAPI client SDK for clients.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: a520e98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 3, 2026

βœ… Deploy Preview for learncarddocs canceled.

Name Link
πŸ”¨ Latest commit a520e98
πŸ” Latest deploy log https://app.netlify.com/projects/learncarddocs/deploys/69dee665aca8f70009143a5b

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 3, 2026

βœ… Deploy Preview for staging-learncardapp ready!

Name Link
πŸ”¨ Latest commit a520e98
πŸ” Latest deploy log https://app.netlify.com/projects/staging-learncardapp/deploys/69dee6653106db000837e5ba
😎 Deploy Preview https://deploy-preview-979--staging-learncardapp.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gitstream-cm
Copy link
Copy Markdown
Contributor

gitstream-cm bot commented Feb 3, 2026

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.10.1 Update Open API Client SDKs to version 3.10.2 Feb 6, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch 4 times, most recently from 5da8207 to 0685aa6 Compare February 11, 2026 21:12
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.10.2 Update Open API Client SDKs to version 3.11.0 Feb 11, 2026
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.11.0 Update Open API Client SDKs to version 3.11.1 Feb 13, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch 5 times, most recently from e3f8de9 to 93c1a99 Compare February 20, 2026 19:05
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.11.1 Update Open API Client SDKs to version 3.11.2 Feb 28, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch 2 times, most recently from 58fe173 to 645c418 Compare March 3, 2026 20:56
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.11.2 Update Open API Client SDKs to version 3.11.3 Mar 3, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch 3 times, most recently from b18503f to 7b44087 Compare March 4, 2026 00:47
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.11.3 Update Open API Client SDKs to version 3.12.2 Mar 4, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch from 7b44087 to b15c181 Compare March 4, 2026 22:23
@github-actions github-actions bot force-pushed the open-api-generator branch 3 times, most recently from bd2aa18 to bf48252 Compare March 17, 2026 22:39
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2026

βœ… Deploy Preview for app-store-1-basic-launchpad-app canceled.

Name Link
πŸ”¨ Latest commit a520e98
πŸ” Latest deploy log https://app.netlify.com/projects/app-store-1-basic-launchpad-app/deploys/69dee66581ea2d00089ad3e4

@github-actions github-actions bot force-pushed the open-api-generator branch 2 times, most recently from d753c27 to 796f3a8 Compare March 18, 2026 21:12
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.12.5 Update Open API Client SDKs to version 3.13.0 Mar 18, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch 3 times, most recently from c683ff6 to 9d81bb3 Compare March 25, 2026 19:23
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.13.0 Update Open API Client SDKs to version 3.13.1 Mar 25, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch 6 times, most recently from 2e81d78 to 28ad8d1 Compare March 31, 2026 21:17
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.13.1 Update Open API Client SDKs to version 3.13.2 Mar 31, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch from 28ad8d1 to 91a8534 Compare March 31, 2026 22:57
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.13.2 Update Open API Client SDKs to version 3.13.3 Apr 7, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch from 91a8534 to bc3af02 Compare April 7, 2026 18:23
@github-actions github-actions bot force-pushed the open-api-generator branch from bc3af02 to 534e6db Compare April 8, 2026 18:38
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.13.3 Update Open API Client SDKs to version 3.13.4 Apr 8, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch from 534e6db to 0bb844f Compare April 9, 2026 19:56
@github-actions github-actions bot changed the title Update Open API Client SDKs to version 3.13.4 Update Open API Client SDKs to version 3.13.5 Apr 9, 2026
@github-actions github-actions bot force-pushed the open-api-generator branch from 0bb844f to daa68d0 Compare April 10, 2026 18:13
@Custard7
Copy link
Copy Markdown
Collaborator

@claude review

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 11, 2026

Claude finished @Custard7's task β€”β€” View job


Code Review: Update Open API Client SDKs to version 3.13.5

Review Summary: This PR updates the Python OpenAPI client generated code to version 7.22.0-SNAPSHOT, adding substantial new API functionality and updating existing models.

Review Findings:

βœ… Positive Aspects:

  • Generated Code Quality: All changes appear to be legitimate OpenAPI generator output with proper structure and documentation
  • Security: No dangerous patterns found - no eval(), dangerouslySetInnerHTML, hardcoded secrets, or malicious imports
  • API Completeness: Significant additions to API coverage, including new endpoints for:
    • App Store functionality (signing authority association, credential retrieval)
    • Enhanced Boost management (revocation, skill alignment, semantic search)
    • New skills search capabilities
    • Additional contract and profile management endpoints

πŸ“‹ Key Changes:

  1. OpenAPI Generator Update: Version bumped to 7.22.0-SNAPSHOT in packages/open-api-lcn-clients/python-client/.openapi-generator/VERSION:1
  2. New API Endpoints:
    • App Store signing authority management
    • Boost revocation functionality
    • Skills semantic search
    • Enhanced credential retrieval
  3. Model Updates: Various response models enhanced with additional fields and union types
  4. Documentation: All new endpoints include comprehensive documentation and examples

⚠️ Areas for Attention:

  • Missing Changeset: As noted by changeset-bot, this PR lacks a changeset for versioning
  • Missing Jira Reference: GitStream flagged missing Jira ticket reference
  • Generated Code Size: Large volume of changes (+14K/-4K) typical for OpenAPI updates but worth noting

🚫 Auto-Approval Assessment:

Cannot be auto-approved due to hard-stop rules:

  • ❌ Author: github-actions (automated commits are blocked from auto-approval)
  • ❌ Generated client code: While not explicitly blocked, these changes affect API client interfaces used across the system

πŸ” Detailed Technical Review:

  • Code Structure: Properly formatted Python with appropriate type hints
  • API Patterns: Consistent with existing OpenAPI client patterns
  • Error Handling: Standard HTTP status code handling maintained
  • Authentication: Bearer token authentication properly implemented
  • Documentation: Comprehensive endpoint documentation with examples

πŸ“ Recommendations:

  1. Add Changeset: Create appropriate changeset for version tracking
  2. Integration Testing: Verify new endpoints work correctly with backend API
  3. Documentation Update: Consider updating higher-level docs if new functionality is user-facing
  4. Jira Reference: Add relevant ticket reference to PR description

βœ… Approval Decision:

Manual review required - While the generated code appears clean and well-formed, the automated authorship and significant API changes warrant human review before merge.


Job Run:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants