fix: preserve host ownership for learn-card-app docker dev#1130
fix: preserve host ownership for learn-card-app docker dev#1130Computer8004 wants to merge 1 commit intolearningeconomy:mainfrom
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | cc0bafe |
|
✅ Deploy Preview for learncarddocs canceled.
|
✅ Deploy Preview for app-store-1-basic-launchpad-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This PR is missing a Jira ticket reference in the title or description. |
There was a problem hiding this comment.
✨ PR Review
LGTM
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how
|
🥷 Code experts: TaylorBeeston TaylorBeeston has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
Summary
LOCAL_UID/LOCAL_GIDin the learn-card-app dev scriptsRoot cause
apps/learn-card-app/compose-local.yamlbind-mounts../../packagesinto containers that were running as root. When Nx rebuilt workspace packages from Docker, it wrotedistoutputs back to the host asroot, which then broke local non-Docker builds.Validation
LOCAL_UID=$(id -u) LOCAL_GID=$(id -g) docker compose -f compose-local.yaml run --rm --no-deps watcher idLOCAL_UID=$(id -u) LOCAL_GID=$(id -g) docker compose -f compose-local.yaml run --rm --no-deps app idLOCAL_UID=$(id -u) LOCAL_GID=$(id -g) docker compose -f compose-local.yaml run --rm --no-deps watcher pnpm exec nx show projectsLOCAL_UID=$(id -u) LOCAL_GID=$(id -g) docker compose -f compose-local.yaml run --rm --no-deps watcher pnpm exec nx run helpers:buildstat -c '%u:%g %n' packages/learn-card-helpers/distRelated: TAY-193 / LC-1725
✨ PR Description
Purpose: Fix file ownership and permission issues in Docker development environment to prevent root-owned files on host system when running learn-card-app containers.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how