Skip to content

chore: set max-width for large screens and fix margins#911

Open
siddarthkay wants to merge 1 commit intolayer5io:masterfrom
siddarthkay:fix-max-width-on-large-screens
Open

chore: set max-width for large screens and fix margins#911
siddarthkay wants to merge 1 commit intolayer5io:masterfrom
siddarthkay:fix-max-width-on-large-screens

Conversation

@siddarthkay
Copy link

Notes for Reviewers

This PR fixes 624

  • set a site-max-width var which i use in navbar and container-fluid classes.
  • also fix margin in footer to remove left and right margin which interferes with max-width setting.

Looks good now.

Screenshot 2026-03-06 at 8 05 14 AM

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Mar 6, 2026

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 92a4363
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/69ac48b3e505c00008b24ec5
😎 Deploy Preview https://deploy-preview-911--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@siddarthkay siddarthkay force-pushed the fix-max-width-on-large-screens branch 4 times, most recently from 68a150d to a652cf7 Compare March 6, 2026 02:51
fixes: layer5io#624
Signed-off-by: Siddarth Kumar <siddarthkay@gmail.com>
@Bhumikagarggg
Copy link
Contributor

@siddarthkay Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@siddarthkay
Copy link
Author

Hi @Bhumikagarggg : I won't be able to join this call, I have a full time job and do open source in free time.
The PR diff is very minimal and shouldn't need a call to explain/discuss.
Any engineer on the team could give a brief look and provide feedback on the PR itself.

I'll look forward to the feedback.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Max-Width on Larger screens causes Layout Break

2 participants