fix(product-reviews): fetch product_review relation on order line items in upsert workflow#35
Open
fix(product-reviews): fetch product_review relation on order line items in upsert workflow#35
Conversation
…ms in upsert workflow The useQueryGraphStep was only fetching 'items.*' which does not traverse the product_review link on each line item. As a result, lineItem.product_review was always undefined, causing every upsert to create a new review instead of updating the existing one. Fixes #33
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe order query in the upsert-product-reviews workflow was extended to include product review fields from order items by adding "items.product_review.*" to the field set. This enables the workflow to retrieve product review data associated with each order item. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #33
When calling
sdk.store.productReviews.upsert, the upsert workflow fetches the order and its line items to determine whether to create or update a review. However, the query only includeditems.*, which fetches shallow fields on each line item — it does not traverse theproduct_reviewlink.As a result,
lineItem.product_reviewwas alwaysundefined, so the workflow always fell into the create path and never updated an existing review.Fix
Add
"items.product_review.*"to theuseQueryGraphStepfields so Medusa's query graph traverses the link and returns the existing product review (if any) for each line item.Summary by CodeRabbit