Skip to content

⚡ Optimize uniq performance for primitives #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaruesink wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize uniq performance for primitives #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/components/src/ui/data-table-filter/lib/array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,19 @@ function deepEqual(a: unknown, b: unknown): boolean {
export function uniq<T>(arr: T[]): T[] {
// Use a Map where key is the deep hash and value is an array of items sharing the same hash.
const seen = new Map<string, T[]>();
const primitives = new Set<unknown>();
const result: T[] = [];

for (const item of arr) {
const type = typeof item;
if (item === null || (type !== 'object' && type !== 'function')) {
if (!primitives.has(item)) {
primitives.add(item);
result.push(item);
}
continue;
}

const hash = deepHash(item);
if (seen.has(hash)) {
// There is a potential duplicate; check the stored items with the same hash.
Expand Down