Simplify Bundle to accept single file instead of list#37
Merged
LilyFirefly merged 1 commit intokraken-tech:mainfrom Jan 30, 2026
Merged
Conversation
Contributor
Author
|
I might explore the idea of removing the |
LilyFirefly
approved these changes
Jan 29, 2026
Contributor
LilyFirefly
left a comment
LilyFirefly
left a comment
There was a problem hiding this comment.
Looks good to me! I think continuing to move to exposing Resource rather than Bundle makes sense too. If we discover in the future that we do need the existing behaviour we can always add back support.
LilyFirefly
reviewed
Jan 29, 2026
tests/test_python_interface.py
Outdated
Comment on lines
+201
to
+189
| 2 │ | ||
| 2 │ |
Contributor
There was a problem hiding this comment.
It looks like this whitespace is load-bearing.
Contributor
Author
There was a problem hiding this comment.
I re-added it for now, but the linter keeps removing it automatically which is very annoying. Thanks for the review!
The Bundle constructor now takes a single ftl_filename parameter instead of a list of filenames. We don't need to support multiple locations for files, nor multiple files in a Bundle
salvatore-giammanco
force-pushed
the
refactor/simplify-rust-api
branch
from
e1e29fa to
8044f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Bundleconstructor now takes a singleftl_filenameparameter instead of a list of filenames. We don't need to support multiple locations or multiple files in a Bundle.Future consideration
Explore removing the
Bundleconcept entirely and simplifying to aResourceas described in the fluent-bundle crate.