⚡ Bolt: Optimize SQL generation in D1 build_delete_stmt

[bashandbone]

💡 What: Optimized SQL query string generation in build_delete_stmt (crates/flow/src/targets/d1.rs) by replacing format! and Vec::join with direct std::fmt::Write operations into a pre-allocated String::with_capacity.
🎯 Why: Avoiding intermediate vector allocations (e.g., where_clauses) and multiple intermediate strings (from the format! loop) reduces unnecessary memory fragmentation and allocations during performance-critical SQL generation.
📊 Impact: Considerably faster query string building during delete operations due to minimal O(N) heap allocations, making D1 table mutations more efficient.
🔬 Measurement: Verified using cargo test -p thread-flow --test d1_target_tests --test d1_minimal_tests to ensure exact semantic correctness and no regression.

---

PR created automatically by Jules for task 15074495455740236939 started by @bashandbone

Summary by Sourcery

Optimize D1 delete statement SQL generation and apply minor code formatting cleanups across AST and rule engine modules.

Enhancements:

• Improve D1 delete SQL construction to avoid intermediate allocations and reduce overhead during key-based deletions.
• Reformat string handling in the AST engine to a more compact style without changing behavior.
• Tidy rule engine code formatting for readability in variable collection and registration access.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Optimizes SQL DELETE statement construction in D1 by writing directly into a preallocated String and minorly refactors code formatting and error-handling style in AST and rule engine modules for consistency.

File-Level Changes

Change	Details	Files
Optimize D1 DELETE SQL generation to avoid intermediate allocations and reduce heap usage during key-based deletes.	Preallocate the parameters vector based on key_fields_schema length. Replace intermediate where_clauses Vec and join with direct writing into a pre-sized SQL String via std::fmt::Write. Construct the DELETE ... WHERE ... SQL statement incrementally with manual " AND " separators instead of format! in a loop. Keep parameter JSON conversion logic the same while aligning pushes with the new loop structure.	crates/flow/src/targets/d1.rs
Minor style/formatting adjustments in AST engine and rule engine for more idiomatic chaining and multi-line expressions.	Inline the unwrap_or_else call for String::from_utf8 to a single expressive chain without altering behavior. Format a multi-line assert_eq! in tests for better readability. Reformat the Rule::Pattern defined_vars mapping to a multi-line iterator chain for clarity. Simplify the Registration::read() lock error handling into a single chained expression.	crates/ast-engine/src/tree_sitter/mod.rs crates/rule-engine/src/rule/mod.rs crates/rule-engine/src/rule/referent_rule.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In build_delete_stmt, you’re silently ignoring the write! results; consider at least a debug_assert!(res.is_ok()) or an expect with a message so unexpected formatting errors don’t get swallowed.
• The String::with_capacity(32 + self.table_name.len() + self.key_fields_schema.len() * 20) uses magic numbers; consider factoring these into named constants or documenting the sizing assumptions so future changes to key name lengths don’t silently defeat the optimization.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `build_delete_stmt`, you’re silently ignoring the `write!` results; consider at least a `debug_assert!(res.is_ok())` or an `expect` with a message so unexpected formatting errors don’t get swallowed.
- The `String::with_capacity(32 + self.table_name.len() + self.key_fields_schema.len() * 20)` uses magic numbers; consider factoring these into named constants or documenting the sizing assumptions so future changes to key name lengths don’t silently defeat the optimization.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

This PR optimizes D1 DELETE SQL generation in D1ExportContext::build_delete_stmt by constructing the query via direct std::fmt::Write into a pre-allocated String, reducing intermediate allocations in a performance-sensitive path.

Changes:

• Reworked build_delete_stmt to build the SQL string incrementally (no format! per clause and no Vec::join).
• Minor formatting-only changes across a few Rust modules/tests (line wrapping / expression formatting).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
crates/rule-engine/src/rule/referent_rule.rs	Formatting-only: condensed chained calls into a single line.
crates/rule-engine/src/rule/mod.rs	Formatting-only: multi-line formatting for the Rule::Pattern match arm.
crates/flow/src/targets/d1.rs	Core change: optimized DELETE SQL string construction and parameter vector pre-allocation.
crates/ast-engine/src/tree_sitter/mod.rs	Formatting-only: condensed unwrap_or_else and expanded assert_eq! for readability.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.