Skip to content

DEVOPS-3809: Incremental version bumps for AP 5.12.0#79

Merged
knime-ghub-bot merged 1 commit intomasterfrom
todo/DEVOPS-3809-version-bumps-for-5.12.0
Mar 5, 2026
Merged

DEVOPS-3809: Incremental version bumps for AP 5.12.0#79
knime-ghub-bot merged 1 commit intomasterfrom
todo/DEVOPS-3809-version-bumps-for-5.12.0

Conversation

@LeoWoerteler
Copy link
Contributor

DEVOPS-3809 (Incremental version bumps for AP 5.12.0)

DEVOPS-3809 (Incremental version bumps for AP 5.12.0)
Copilot AI review requested due to automatic review settings March 5, 2026 14:19
@LeoWoerteler LeoWoerteler requested a review from a team as a code owner March 5, 2026 14:19
@LeoWoerteler LeoWoerteler requested review from knime-ghub-bot and removed request for a team March 5, 2026 14:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs incremental version bumps to align the KNIME Python integration bundles/features with the Analytics Platform (AP) 5.12.0 release baseline.

Changes:

  • Bump bundle versions to 5.12.0.qualifier for org.knime.python3.scripting.nodes and org.knime.python3.arrow.
  • Update selected Require-Bundle minimum versions to 5.12.0 where applicable.
  • Bump feature versions/requirements to 5.12.0 for the Python 3 scripting and nodes features.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
org.knime.python3.scripting.nodes/META-INF/MANIFEST.MF Bundle version bumped to 5.12 and several required-bundle lower bounds updated.
org.knime.python3.arrow/META-INF/MANIFEST.MF Bundle version bumped to 5.12 and selected required-bundle lower bounds updated.
org.knime.features.python3.scripting/feature.xml Updates required import minimum version for core columnar to 5.12.
org.knime.features.python3.nodes/feature.xml Feature version bumped to 5.12 and core columnar requirement updated to 5.12.

Require-Bundle: org.knime.core;bundle-version="[5.12.0,6.0.0)",
org.knime.base;bundle-version="[5.12.0,6.0.0)",
org.knime.core.columnar.arrow;bundle-version="[5.12.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required bundle version bounds are inconsistent: this bundle now requires org.knime.core and org.knime.core.columnar.arrow >= 5.12.0, but still allows org.knime.core.columnar >= 5.11.0. For an AP 5.12.0 baseline bump, consider raising org.knime.core.columnar’s lower bound to 5.12.0 as well to avoid resolving against an older columnar bundle.

Suggested change
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.12.0,6.0.0)",

Copilot uses AI. Check for mistakes.
Comment on lines 24 to 25
org.knime.conda;bundle-version="[5.11.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.11.0,6.0.0)",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.knime.conda and org.knime.conda.envbundling are still pinned to a >= 5.11.0 lower bound while other AP dependencies in this manifest were bumped to >= 5.12.0. If the goal is to enforce an AP 5.12.0 baseline, these should likely be bumped to >= 5.12.0 for consistency (and to match the feature requirement on org.knime.features.conda 5.12.0).

Suggested change
org.knime.conda;bundle-version="[5.11.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.11.0,6.0.0)",
org.knime.conda;bundle-version="[5.12.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.12.0,6.0.0)",

Copilot uses AI. Check for mistakes.
Bundle-ActivationPolicy: lazy
Require-Bundle: org.knime.python3;bundle-version="[5.11.0,6.0.0)",
org.knime.core.table;bundle-version="[5.9.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bundle now requires org.knime.core >= 5.12.0 and org.knime.core.columnar.arrow >= 5.12.0, but still allows org.knime.core.columnar >= 5.11.0. Consider bumping org.knime.core.columnar’s lower bound to 5.12.0 as well to keep the dependency baseline consistent for AP 5.12.0.

Suggested change
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.12.0,6.0.0)",

Copilot uses AI. Check for mistakes.
<import feature="org.knime.features.conda" version="5.12.0" match="greaterOrEqual"/>
<import feature="org.knime.features.core.columnar" version="5.11.0" match="greaterOrEqual"/>
<import feature="org.knime.features.core.columnar" version="5.12.0" match="greaterOrEqual"/>
<import feature="org.knime.features.pythonscripting" version="5.11.0" match="greaterOrEqual"/>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the AP 5.12.0 version-bump context, the required features were mostly bumped to 5.12.0, but org.knime.features.pythonscripting is still listed with a 5.11.0 lower bound. If the intention is to require a full 5.12.0 baseline, this import should likely be updated to 5.12.0 for consistency.

Suggested change
<import feature="org.knime.features.pythonscripting" version="5.11.0" match="greaterOrEqual"/>
<import feature="org.knime.features.pythonscripting" version="5.12.0" match="greaterOrEqual"/>

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

@knime-ghub-bot knime-ghub-bot merged commit 186bc7a into master Mar 5, 2026
7 of 9 checks passed
@knime-ghub-bot knime-ghub-bot deleted the todo/DEVOPS-3809-version-bumps-for-5.12.0 branch March 5, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants