Skip to content

refactor(web): spin off default keep-generation from suggestionSimilarity 🚂#15766

Merged
jahorton merged 2 commits intoepic/autocorrectfrom
refactor/web/create-default-keep
Apr 9, 2026
Merged

refactor(web): spin off default keep-generation from suggestionSimilarity 🚂#15766
jahorton merged 2 commits intoepic/autocorrectfrom
refactor/web/create-default-keep

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

@jahorton jahorton commented Mar 17, 2026

This gives us smaller, more specialized methods - something that's usually a win of its own. It may also help facilitate further adjustments needed for support of whitespace fat-finger prediction & autocorrection.

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Mar 17, 2026

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(web): spin off default keep-generation from suggestionSimilarity refactor(web): spin off default keep-generation from suggestionSimilarity 🚂 Mar 17, 2026
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S25 milestone Mar 17, 2026
@keyman-server keyman-server modified the milestones: A19S25, A19S26 Mar 28, 2026
…rity

This gives us smaller, more specialized methods - something that's usually a win of its own.  It will also help facilitate further adjustments needed for support of whitespace fat-finger prediction & autocorrection.

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton changed the base branch from change/web/tag-suggestion-id-during-finalize to epic/autocorrect April 2, 2026 19:26
@jahorton jahorton force-pushed the refactor/web/create-default-keep branch from a53305b to d285478 Compare April 2, 2026 19:26
@jahorton jahorton marked this pull request as ready for review April 2, 2026 19:28
Comment thread web/src/engine/predictive-text/worker-thread/src/main/predict-helpers.ts Outdated
Comment thread web/src/engine/predictive-text/worker-thread/src/main/model-compositor.ts Outdated
@jahorton jahorton merged commit 2b2ef41 into epic/autocorrect Apr 9, 2026
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Apr 9, 2026
@jahorton jahorton deleted the refactor/web/create-default-keep branch April 9, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants