fix: Start to incorporate lang in URL paths 🌋 by darcywong00 · Pull Request #704 · keymanapp/keyman.com

darcywong00 · 2026-03-31T03:39:53Z

Follows #696

This overhauls .htaccess files to handle a langtag in the URL path (rewrite to corresponding _content/ path).
Flow of .htaccess:

Redirections before rewriting
Remove file extensions from links
Known path redirections
i18n redirect --> /file to /file
Rewrite rules

Additional small changes:

Moved ‎_content/archive/.htaccess rule to the root .htaccess
cleanup downloads path
cleanup some _test page links
Reverts $fields->lang in Foot and Menu from fix: Convert some absolute paths to relative 🌋 #692 since .htaccess handles the language params

CI link checker ~~will~~ may still fail

Test-bot: skip

* From rubber-ducky with MD

keymanapp-test-bot · 2026-03-31T03:39:58Z

User Test Results

Test specification and instructions

User tests are not required

.htaccess

* These folders don't use _content

1. remove .php / .md 2. redirects before rewrites 3. rewrite locale to lang= parameter 4. final cleanup

also cleaned up test pages

darcywong00 · 2026-04-07T00:53:32Z

_content/android/app/index.php

@@ -0,0 +1,4 @@
+<?php
+    // Redirect to Android homepage
+    header('Location: https://help.keyman.com/products/android/');


Converted from /_content/android/app/.htaccess - also done for iphone-and-ipad/app

Root .htaccess rules weren't matching

I'm a little uncomfortable with this change -- it might be better to add the rule at the top level .htaccess?

mcdurdin · 2026-04-07T13:57:58Z

.htaccess

+# Remove .php extension and redirect
+#RewriteCond "$1.php" -f
+#RewriteCond "$1" !-d
+RewriteRule "^(.+).php$" "$1" [R,L]


We need the same pattern for Markdown I think

Suggested change

RewriteRule "^(.+).php$" "$1" [R,L]

RewriteRule "^(.+)\.php$" "$1" [R,L]

RewriteRule "^(.+)\.md$" "$1" [R,L]

See for example:

http://keyman.com.localhost/en/about/team/bios/darcywong00.md should redirect to http://keyman.com.localhost/en/about/team/bios/darcywong00

mcdurdin · 2026-04-07T13:58:57Z

.htaccess

+# ------------------------------------------------------------------
+
+# Remove index.md or index.php and redirect (and stop processing)
+#RewriteCond "$1" -d


Suggested change

#RewriteCond "$1" -d

mcdurdin · 2026-04-07T13:59:02Z

.htaccess

+#RewriteCond "$1.php" -f
+#RewriteCond "$1" !-d


Suggested change

#RewriteCond "$1.php" -f

#RewriteCond "$1" !-d

mcdurdin · 2026-04-07T14:00:07Z

.htaccess

+
+# Remove index.md or index.php and redirect (and stop processing)
+#RewriteCond "$1" -d
+RewriteRule "^((.+)/)?index(.md|.php)?$" "$1" [R,L]


Suggested change

RewriteRule "^((.+)/)?index(.md|.php)?$" "$1" [R,L]

RewriteRule "^((.+)/)?index(\.md|\.php)?$" "$1" [R,L]

mcdurdin · 2026-04-07T14:00:35Z

.htaccess

+# ------------------------------------------------------------------
+
+# Redirect /archive/downloads.php"
+RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,QSA]


Suggested change

RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,QSA]

RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,END,QSA]

? I am not sure if END is required for redirects?

mcdurdin · 2026-04-07T14:12:56Z

_content/keyboards/h/tamil/index.php

  </div>
  <div class="download-cta-small iPad" id="cta-iPad">
-    <a href="../../../ipad/">
+    <a href="../../../../ipad/">


mcdurdin · 2026-04-07T14:13:13Z

_content/keyboards/h/urdu/index.php

  </div>
  <!--<div class="download-cta-small Bookmarklet" id="cta-Bookmarklet">
-    <a href="../../../bookmarklet/">
+    <a href="../../../../bookmarklet/">


Suggested change

<a href="../../../../bookmarklet/">

<a href="../../../bookmarklet/">

mcdurdin · 2026-04-07T14:13:47Z

_content/windows/index.php

 </p>
 <p>
-    <span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads.php">here</a>.
+    <span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="/archive/downloads">here</a>.


Suggested change

<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="/archive/downloads">here</a>.

<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads">here</a>.

Why make the path absolute again?

mcdurdin · 2026-04-07T14:14:39Z

_includes/2020/templates/Foot.php

-      // Fallback to 'en'
-      // TODO-I18N-URL-SCHEME: integrate with Locale.php
-      $fields->lang = isset($_REQUEST['lang']) ? $_REQUEST['lang'] : 'en';


Why remove this? We'll need something like this throughout

mcdurdin · 2026-04-07T14:15:05Z

_test/index.md

 ## Links to Other Test Pages

-[/go links](./go)
+[/go links](/_test/go)


Why this change?

darcywong00 added 4 commits March 26, 2026 14:46

fix: .htaccess for including <lang> in the URL

6f8fdae

* From rubber-ducky with MD

fix: more rewrites involving _content

863f677

fix: Add lang to Head.php

d98b236

fix: redirects to currentlang

f4d6d99

darcywong00 added this to the A19S26 milestone Mar 31, 2026

darcywong00 requested a review from mcdurdin March 31, 2026 03:39

keyman-status added this to Keyman Mar 31, 2026

github-actions bot added the fix label Mar 31, 2026

keymanapp-test-bot bot added the epic-i18n-url-scheme label Mar 31, 2026

github-project-automation bot moved this to Todo in Keyman Mar 31, 2026

darcywong00 added 2 commits March 31, 2026 14:26

fix: remove .php from links

91d69b5

tweak regex

cd9fd45

darcywong00 commented Apr 1, 2026

View reviewed changes

.htaccess Outdated Show resolved Hide resolved

darcywong00 added 7 commits April 1, 2026 13:16

Merge branch 'epic/i18n-url-scheme' into fix/lang/htaccess

8b3f67e

fix 404

a0f3d86

fix en routing

3804817

fix: Handle _control, go, and _test

839fb40

* These folders don't use _content

refactor: reorder .htaccess

1583b34

1. remove .php / .md 2. redirects before rewrites 3. rewrite locale to lang= parameter 4. final cleanup

chore: remove old root rule

7ca0e01

fix: downloads/releases paths

57ad35d

darcywong00 marked this pull request as draft April 2, 2026 08:49

darcywong00 added 2 commits April 2, 2026 16:00

fix: keyboard rewrites

37273da

chore: more cleanup

95bbf29

darcywong00 marked this pull request as ready for review April 6, 2026 01:21

fix /archive/downloads redirect

bf9897e

darcywong00 force-pushed the fix/lang/htaccess branch from 7a87423 to bf9897e Compare April 6, 2026 02:16

darcywong00 added 3 commits April 6, 2026 09:36

fix: keyboards/download query

7634f84

fix /contact/exception

93bad37

also cleaned up test pages

fix menu link to "Help and Documentation"

53ba79a

darcywong00 added 7 commits April 6, 2026 10:58

chore: cleanup more _test paths

35f00a4

revert $fields->lang in template links

3822271

fix keyboard landing page links

a92ac18

fix more landing links

7965b0a

try to fix more keyboard landing links

5c1970b

fix: handle assets

be580bd

fix ios links so they can be relative

224561f

darcywong00 commented Apr 7, 2026

View reviewed changes

darcywong00 added 4 commits April 7, 2026 07:59

revert _test/index.md changes

948550f

fix: Use absolute paths for _test/ page

b37b468

fix: re-enable 404 pages

5dd6beb

fixup cdn asset links

11c3a70

mcdurdin requested changes Apr 7, 2026

View reviewed changes

	RewriteRule "^(.+).php$" "$1" [R,L]
	RewriteRule "^(.+)\.php$" "$1" [R,L]
	RewriteRule "^(.+)\.md$" "$1" [R,L]

	RewriteRule "^((.+)/)?index(.md\|.php)?$" "$1" [R,L]
	RewriteRule "^((.+)/)?index(\.md\|\.php)?$" "$1" [R,L]

	RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,QSA]
	RewriteRule "^archive/downloads(.php)?$" "/downloads/archive/" [NC,R=301,END,QSA]

	<a href="../../../../bookmarklet/">
	<a href="../../../bookmarklet/">

	<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="/archive/downloads">here</a>.
	<span class="red">A.</span> Yes, you can find the links to download Keyman Desktop 7.1 and other previous releases <a href="../archive/downloads">here</a>.

Uh oh!

Conversation

darcywong00 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keymanapp-test-bot bot commented Mar 31, 2026

User Test Results

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

darcywong00 commented Mar 31, 2026 •

edited

Loading