Skip to content

Disable passkey autofill popup in browser VMs #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masnwilliams wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Disable passkey autofill popup in browser VMs #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/chromium-headless/image/wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ if [ -z "${CHROMIUM_FLAGS:-}" ]; then
--disable-crash-reporter \
--disable-crashpad \
--disable-dev-shm-usage \
--disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DeferRendererTasksAfterInput,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,ImprovedCookieControls,LazyFrameLoading,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate \
--disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DeferRendererTasksAfterInput,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,ImprovedCookieControls,LazyFrameLoading,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Translate,WebAuthenticationConditionalUI \
--disable-field-trial-config \
--disable-gcm-registration \
--disable-gpu \
Expand Down
1 change: 1 addition & 0 deletions server/cmd/chromium-launcher/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ func main() {
"--user-data-dir=/home/kernel/user-data",
"--password-store=basic",
"--no-first-run",
"--disable-features=WebAuthenticationConditionalUI",
Copy link

@cursor cursor bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded --disable-features silently overridden by later flag

Medium Severity

Chromium uses last-one-wins semantics for duplicate --disable-features flags. The hardcoded --disable-features=WebAuthenticationConditionalUI in chromiumArgs is placed before final is appended (line 70), so any --disable-features entry in final silently overrides it. In headless mode this happens every time — wrapper.sh's comprehensive --disable-features list lands in final and replaces the hardcoded one. It works today only because wrapper.sh independently added WebAuthenticationConditionalUI. If the two lists ever diverge, or if headful runtime flags introduce a --disable-features, the hardcoded flag labeled "flags we send no matter what" will have no effect.

Additional Locations (1)

Fix in Cursor Fix in Web

}
if *headless {
chromiumArgs = append([]string{"--headless=new"}, chromiumArgs...)
Expand Down
Loading