Add standby / restore support for Mac vz hypervisor#115
Open
sjmiller609 wants to merge 3 commits intomainfrom
Open
Add standby / restore support for Mac vz hypervisor#115sjmiller609 wants to merge 3 commits intomainfrom
sjmiller609 wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note
Medium Risk
Adds save/restore snapshotting to the
vzhypervisor (stateful VM lifecycle and on-disk manifests), which can affect VM availability and data integrity if compatibility/validation or file handling is wrong. Scoped to macOS 14+ Apple Silicon and gated by capability checks, but still touches core VM lifecycle paths.Overview
Enables standby/restore for the macOS
vzhypervisor by adding avz-shimPUT /api/v1/vm.snapshotendpoint that saves machine state to disk and writes a snapshot manifest (config.json) for later restore.Adds restore boot flow to
vz-shim(start vs restore based onRestoreMachineStatePath), persists platform identity via a stable generic machine identifier, disables the memory balloon device to improve save/restore compatibility, and extends VM state reporting to include save/restore-related states.Wires this through
lib/hypervisor/vz:Client.Snapshot()is implemented with a long-running HTTP client andCapabilities().SupportsSnapshotbecomesarm64-only;Starter.RestoreVM()is implemented to read the manifest and start the shim in restore mode. Adds a darwin/arm64 integration test covering the full standby→restore cycle, updates docs/README wording, and makes Go test timeouts configurable viaGO_TEST_TIMEOUT(set to600sin CI).Written by Cursor Bugbot for commit 6909797. This will update automatically on new commits. Configure here.