Add --query flag to kernel browsers list#126
Merged
dcruzeneil2 merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
And related test
masnwilliams
approved these changes
Feb 27, 2026
Contributor
masnwilliams
left a comment
masnwilliams
left a comment
There was a problem hiding this comment.
looks good, one small nit
|
|
||
| var captured kernel.BrowserListParams | ||
| fake := &FakeBrowsersService{ | ||
| ListFunc: func(ctx context.Context, query kernel.BrowserListParams, opts ...option.RequestOption) (*pagination.OffsetPagination[kernel.BrowserListResponse], error) { |
Contributor
There was a problem hiding this comment.
nit: the other list tests in this file name this parameter params — worth matching for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And related test
Note
Low Risk
Low risk: adds an optional list filter flag and passes it through to the SDK, with a small unit test verifying param wiring.
Overview
Adds a new
--queryflag tokernel browsers listand threads it throughBrowsersListInputintokernel.BrowserListParams.Queryso list results can be searched (session/profile/proxy IDs).Adds a unit test ensuring the query value is passed to the underlying
BrowsersService.Listcall.Written by Cursor Bugbot for commit 64b55db. This will update automatically on new commits. Configure here.