Remove jars and rig build to ensure they are downloaded#104
Merged
Conversation
Member
headius
commented
May 8, 2026
headius
commented
- Remove all the jars from the repo; we should not version them.
- Move the list of jar URLs and SHA1s to a library constant.
- Use the list to ensure they are present before building the gem.
headius
force-pushed
the
master
branch
2 times, most recently
from
f128f46 to
8160f94
Compare
* Remove all the jars from the repo; we should not version them. * Move the list of jar URLs and SHA1s to a library constant. * Use the list to ensure they are present before building the gem.
Member
Author
|
In order to remove the accidentally committed jars, I've rewritten all commits from #102 and rebased this PR upon that history. |
Member
Author
|
@kares Review requested. I had to rewrite your commits on master to remove the jars; we don't want several MB of dead binary data in this repo if we can avoid it. |
kares
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.