review logging + dedicated load-error#103
Open
kares wants to merge 4 commits intojruby:masterfrom
Open
Conversation
headius
force-pushed
the
master
branch
2 times, most recently
from
f128f46 to
8160f94
Compare
Member
|
@kares Rebase this on the rewritten master. I had to remove the jars. |
kares
force-pushed
the
review-logging
branch
2 times, most recently
from
8df7280 to
efb5df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one notable "breaking" change -> changing jar load error from a generic
RuntimeError->JarLoadErrorhas been always difficult not being able to catch a "load-error" with user-code relying on
require_jarfigured the new MIMA 0.6.x in the works might be good enough to introduce the error
also reviewed logging formatting (which was always a bit challenging to work with when debugging jar issues)