Improve board position management by dynaman216 · Pull Request #14 · jrmi/react-sync-board

dynaman216 · 2026-03-02T19:05:38Z

No description provided.

netlify · 2026-03-02T19:05:43Z

✅ Deploy Preview for react-sync-board ready!

Name	Link
🔨 Latest commit	`efbd4f5`
🔍 Latest deploy log	https://app.netlify.com/projects/react-sync-board/deploys/69ade8643ce9800008f9fdc3
😎 Deploy Preview	https://deploy-preview-14--react-sync-board.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

jrmi

Hey @dynaman216 I made a first review of your job. First I want to thank you for your contribution. I can see you look more comfortable with React now 😉

I left a few comments and questions, I'd love to hear your thoughts about that.

Let me know if you need more details.

src/example/Main.jsx

src/lib/board/useDim.js

jrmi · 2026-03-07T20:32:37Z

src/lib/board/useDim.js

        ...translateFn({
-          translateX: prev.translateX,
-          translateY: prev.translateY,
+          translateX: 0,


What do you think to center the view at the center of the item extent instead of the center of the board? The center of the board could be empty and I think it doesn't really make sense to center in an empty location. Actually look at the PanZoom component, there is this centerBoard function, may be that's exactly what you want to achieve but not only on startup but when we click on a button (which makes a lot of sense).

Even centering at the center of item extent could be empty. It items are off to the top left and top right (off the board) then centering there would be empty. To recreate that start up the demo, drag half the items off the top left and the other half off the bottom right so they are not visible and center. Nothing will show up even though the view is in the "center" of the objects.

Even centering at the center of item extent could be empty.
There is probably no perfect solution but at least it should work in most of the real cases. Creating a game with items at opposite of the space without anything in the middle looks slightly unusual don't you think?

At least for now none of the game in ABG are like that and the current centering is working great for all of them.

Actually for legacy reasons part of the games were created when the center was actually the top left corner so for this games chances are great that we don't see anything.

What do you think?

jrmi · 2026-03-07T20:38:35Z

.npmignore

+target
+build
+coverage
+test


I have the feeling these lines are duplicated, is there any reason?

Hit the resolved by accident. Toolset did this again. I'll remove them.

Have you pushed your changes because I can still see the changes.

.gitignore

jrmi · 2026-03-07T20:42:32Z

src/lib/board/useDim.js

-  }

+    // Limit move to board limit
+    const distToCenter = distance(screenCenter, [boardCenter.x, boardCenter.y]);


I think with should still keep the board limitations when we don't limit pan otherwise you can see board limit which is not great, what do you think?

I may be making some really large maps so not limiting at all is helpful for that. I was going to suggest having a background color instead of a base image (which is what I think is currently being done).
I am planning on adding a group of 9 buttons instead of just the center button. Each one would set the view to the top left, top middle, top right, left middle, middle, middle right, left bottom, bottom middle, and bottom right. Based on the positions of all the items added so far. laid out like so.

1 2 3
4 5 6
7 8 9

I was going to suggest having a background color instead of a base image (which is what I think is currently being done).

Allowing a repetitive background (svg/image/css) was a request from some users and I think it's a good feature so I'm not sure remove that is a good idea.

Regarding what you want, do you know it's possible to save positions with alt+[number key] and restore them with [number key].

We could imagine that the new feature pre-set the positions as you described, what do you think?

I may be making some really large maps so not limiting at all is helpful for that.

I'm curious to see your game because I imported some of the biggest existing games (using vassal modules) and they all fit in the current board size. I used to play gloomhaven with a lot of space per user and we were really far from reaching the limit. Are you items at the right size? How are they compared to pre-made items?

Also have you noticed that there is a "box" system where you can store your game items when they are not used? May be this will mitigate your need for space? what do you think?

package.json

Changes to fix items listed on 3/7/2026

dynaman216 · 2026-03-08T21:22:47Z

New version 002 pushed today for your review. The changes made as commented on. Once those items are resolved I will start adding more functionality.

jrmi · 2026-03-12T17:48:09Z

package-lock.json

Could you also revert the changes of this file?

jrmi · 2026-03-12T17:49:14Z

New version 002 pushed today for your review. The changes made as commented on. Once those items are resolved I will start adding more functionality.

Hey I tried to answer to the still open comments. I'd love to hear your thoughts.

dynaman216 · 2026-03-12T18:30:44Z

Going to be a while. Im busy the next couple weeks. For centering, I play LARGE miniature war games where the center of the board is often empty for a good while.

…

On Thu, Mar 12, 2026, 1:49 PM Jérémie Pardou ***@***.***> wrote: *jrmi* left a comment (jrmi/react-sync-board#14) <#14 (comment)> New version 002 pushed today for your review. The changes made as commented on. Once those items are resolved I will start adding more functionality. Hey I tried to answer to the still open comments. I'd love to hear your thoughts. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEJ55VVKIDV2ROJ2GJ5LS4L4QL2DBAVCNFSM6AAAAACWESJCQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANBYG42TONZSGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

jrmi · 2026-03-14T10:18:49Z

Going to be a while. Im busy the next couple weeks.

Sure, no problem.

For centering, I play LARGE miniature war games where the center of the board is often empty for a good while.

In this case there is another possibility: the games can define their own initial position (and again you can preset positions like targeting the two sides of the board or each unit), It looks a better solution, what do you think?

I suggest when you have a little time that we discuss (on discord) what are your constraints so we can find a solution that works for all games including yours because I made a lot of small features and some of them are not documentation easily discoverable.

dynaman216 · 2026-03-29T14:49:50Z

I'm getting myself back to programming again. It has been a busy last couple of weeks helping my son move across the country (among other things). Having a preset "center" of some kind is a good idea. For getting together and talking on discord I am in the US in the eastern time zone. Fridays, Saturdays, or Sundays I can usually be available if that works for you. Remember - you are a lot more skilled at this than I am but I am learning.

…

On Sat, Mar 14, 2026 at 6:19 AM Jérémie Pardou ***@***.***> wrote: *jrmi* left a comment (jrmi/react-sync-board#14) <#14 (comment)> Going to be a while. Im busy the next couple weeks. Sure, no problem. For centering, I play LARGE miniature war games where the center of the board is often empty for a good while. In this case there is another possibility: the games can define their own initial position (and again you can preset positions like targeting the two sides of the board or each unit), It looks a better solution, what do you think? I suggest when you have a little time that we discuss (on discord) what are your constraints so we can find a solution that works for all games including yours because I made a lot of small features and some of them are not documentation easily discoverable. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEJ55VQNP6MQ474N7NOWMRL4QUWZ7AVCNFSM6AAAAACWESJCQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRQGIZDMMBTGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

dynaman216 · 2026-03-30T01:35:35Z

As an example of the learning I need to do - it took me all day to figure out that the code used onpointerdown instead of onmousedown (literally JUST found it). Since I am trying to research how objects are selected and moved. More research tomorrow. On Sun, Mar 29, 2026 at 10:49 AM Paul Blankenship ***@***.***> wrote:

…

I'm getting myself back to programming again. It has been a busy last couple of weeks helping my son move across the country (among other things). Having a preset "center" of some kind is a good idea. For getting together and talking on discord I am in the US in the eastern time zone. Fridays, Saturdays, or Sundays I can usually be available if that works for you. Remember - you are a lot more skilled at this than I am but I am learning. On Sat, Mar 14, 2026 at 6:19 AM Jérémie Pardou ***@***.***> wrote: > *jrmi* left a comment (jrmi/react-sync-board#14) > <#14 (comment)> > > Going to be a while. Im busy the next couple weeks. > > Sure, no problem. > > For centering, I play LARGE miniature war games where the center of the > board is often empty for a good while. > > In this case there is another possibility: the games can define their own > initial position (and again you can preset positions like targeting the two > sides of the board or each unit), It looks a better solution, what do you > think? > > I suggest when you have a little time that we discuss (on discord) what > are your constraints so we can find a solution that works for all games > including yours because I made a lot of small features and some of them are > not documentation easily discoverable. > > — > Reply to this email directly, view it on GitHub > <#14 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEJ55VQNP6MQ474N7NOWMRL4QUWZ7AVCNFSM6AAAAACWESJCQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRQGIZDMMBTGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

dynaman216 added 2 commits March 2, 2026 10:10

Initial commit

8d16376

Resolved conflicts by keeping local version

97f00c3

jrmi self-requested a review March 7, 2026 13:09

jrmi changed the title ~~Paul Changes 001~~ Improve board position management Mar 7, 2026

Cleaned Code

af31e87

jrmi requested changes Mar 7, 2026

View reviewed changes

Paul Changes 002

efbd4f5

Changes to fix items listed on 3/7/2026

jrmi reviewed Mar 12, 2026

View reviewed changes

package-lock.json

Copy link
Copy Markdown

Owner

jrmi Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also revert the changes of this file?

Conversation

dynaman216 commented Mar 2, 2026

Uh oh!

netlify bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for react-sync-board ready!

Uh oh!

jrmi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrmi Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dynaman216 commented Mar 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrmi commented Mar 12, 2026

Uh oh!

dynaman216 commented Mar 12, 2026 via email

Uh oh!

jrmi commented Mar 14, 2026

Uh oh!

dynaman216 commented Mar 29, 2026 via email

Uh oh!

dynaman216 commented Mar 30, 2026 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 2, 2026 •

edited

Loading

jrmi Mar 12, 2026 •

edited

Loading