fix: Disable swizzling for macOS 26 and above to prevent crashes#720
fix: Disable swizzling for macOS 26 and above to prevent crashes#720victorlunam wants to merge 1 commit intojordanbaird:mainfrom
Conversation
|
I agree that this would be an acceptable tradeoff to ensure stability. Although, where are you seeing that Do you still get crashes when using the latest beta build? https://github.com/jordanbaird/Ice/releases/tag/0.11.13-dev.2 |
Regarding point 2. Regarding point 1. Full Report on crash (click to expand) |
|
Looks like this is indeed the window number issue I described above. Here's the important part of the crash report (emphasis mine):
If disabling swizzling happens to prevent a crash on your machine, it's likely coincidental, and could come down to something as simple as an order-of-execution issue. Since this technically falls under the category of "undefined behavior", it might not even prevent a crash 100% of the time. As stated, this has been fixed in the latest beta. Work for this is being done on the |
This PR updates swizzle() to prevent crashes on macOS 26+ by skipping the swizzle entirely. A minor UI issue is accepted as a tradeoff to ensure stability.
Changes: