Skip to content

Make conda build platform-independent#88

Open
naegelejd wants to merge 3 commits intomasterfrom
naegelejd/fix-conda-build
Open

Make conda build platform-independent#88
naegelejd wants to merge 3 commits intomasterfrom
naegelejd/fix-conda-build

Conversation

@naegelejd
Copy link
Copy Markdown
Contributor

This library is pure Python so there's no need to build and publish platform-specific conda packages.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the conda packaging pipeline platform-independent by switching the recipe to a noarch: python build, so the same conda artifact can be published and installed across OSes without separate per-platform builds.

Changes:

  • Mark the conda recipe as noarch: python to produce a platform-independent package.
  • Simplify the GitHub Actions conda workflow to build on Ubuntu only.
  • Add a devcontainer configuration for building/publishing conda packages in a containerized environment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
conda/meta.yaml Declares the recipe as noarch: python to enable platform-independent conda artifacts.
.github/workflows/ismrmrd_python_conda.yml Removes the OS matrix and builds conda packages on Ubuntu only.
.devcontainer/devcontainer.json Adds a devcontainer for conda-build/anaconda-client tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread conda/meta.yaml Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants