Skip to content

Add hostname propagation to ironcore-net NetworkInterfaces #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ushabelgur wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add hostname propagation to ironcore-net NetworkInterfaces #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ea870
pass hostname to apinet nic
ushabelgur Jan 22, 2026
2474f40
incorporate review comments
ushabelgur Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/machine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ type NetworkInterfaceSpec struct {
NetworkId string `json:"networkId"`
Ips []string `json:"ips"`
Attributes map[string]string `json:"attributes"`
HostName string `json:"hostName,omitempty"`
}

type NetworkInterfaceStatus struct {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require (
github.com/ironcore-dev/controller-utils v0.10.0
github.com/ironcore-dev/ironcore v0.2.5-0.20251024123813-eecafba97af9
github.com/ironcore-dev/ironcore-image v0.2.5
github.com/ironcore-dev/ironcore-net v0.2.4
github.com/ironcore-dev/ironcore-net v0.2.5-0.20260123094402-a0b32fb0e8ff
github.com/ironcore-dev/provider-utils v0.0.0-20251010114402-394db8015df4
github.com/moby/term v0.5.2
github.com/onsi/ginkgo/v2 v2.27.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ github.com/ironcore-dev/ironcore v0.2.5-0.20251024123813-eecafba97af9 h1:QQfXQO7
github.com/ironcore-dev/ironcore v0.2.5-0.20251024123813-eecafba97af9/go.mod h1:9ATw2BEKZSdtUtNK9sAd+GLrcoxF2iF4Q6S67KqfKow=
github.com/ironcore-dev/ironcore-image v0.2.5 h1:ImJD3B1p1/JVs5vx7YB3c8dwH/EHyWOcgWUqhTUmsR0=
github.com/ironcore-dev/ironcore-image v0.2.5/go.mod h1:pQLc+7dzgjYORTpEM9ORM757Vm14EQRju9hsvR8VT/U=
github.com/ironcore-dev/ironcore-net v0.2.4 h1:r2SqxwStws86KBvxJcK/myRxb946qAZVpPKd1rJzfsQ=
github.com/ironcore-dev/ironcore-net v0.2.4/go.mod h1:dSn6aWF+bxCIeWJzPjDl5dVTH3Rd7wx1LuTQpYUU4Lg=
github.com/ironcore-dev/ironcore-net v0.2.5-0.20260123094402-a0b32fb0e8ff h1:tUnwPIllqJSMc581PIul0kH500EzMJoks1xB7zlie9o=
github.com/ironcore-dev/ironcore-net v0.2.5-0.20260123094402-a0b32fb0e8ff/go.mod h1:jy3F6vLjt+2JMXi39P6NklJ66hJjf12BYEC7eOIy7IA=
github.com/ironcore-dev/provider-utils v0.0.0-20251010114402-394db8015df4 h1:sRQ/gcL5z3CqcqI+9If8XmgVk9pK4WebZOAMNFYXREQ=
github.com/ironcore-dev/provider-utils v0.0.0-20251010114402-394db8015df4/go.mod h1:qxuFuJy31Lfu3go5wsGpFGAZwCw1++1EKGJmHG2HbLw=
github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8HmY=
Expand Down
3 changes: 2 additions & 1 deletion internal/plugins/networkinterface/apinet/apinet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ func (p *Plugin) Apply(ctx context.Context, spec *api.NetworkInterfaceSpec, mach
NodeRef: corev1.LocalObjectReference{
Name: p.nodeName,
},
IPs: ironcoreIPsToAPInetIPs(spec.Ips),
IPs: ironcoreIPsToAPInetIPs(spec.Ips),
Hostname: spec.HostName,
},
}

Expand Down
1 change: 1 addition & 0 deletions internal/server/machine_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ func (s *Server) createMachineFromIRIMachine(ctx context.Context, log logr.Logge
NetworkId: iriNetworkInterface.NetworkId,
Ips: iriNetworkInterface.Ips,
Attributes: iriNetworkInterface.Attributes,
HostName: iriMachine.Metadata.Id,
}
networkInterfaces = append(networkInterfaces, networkInterfaceSpec)
}
Expand Down
Loading