Support new iPython system_raise_on_error flag in ZMQInteractiveShell#1496
Open
adityawasudeo wants to merge 3 commits intoipython:mainfrom
Open
Support new iPython system_raise_on_error flag in ZMQInteractiveShell#1496adityawasudeo wants to merge 3 commits intoipython:mainfrom
adityawasudeo wants to merge 3 commits intoipython:mainfrom
Conversation
Author
|
@ianthomas23 or @JohanMabille , would love to get a review on this when you have a couple of minutes. |
Collaborator
|
Can you rebase this on |
adityawasudeo
force-pushed
the
add-system-raise-on-error
branch
from
5acbbb9 to
196605f
Compare
Add support for IPython's system_raise_on_error configuration option in ZMQInteractiveShell.system_piped() override. This complements the IPython PR that adds the system_raise_on_error config option (see ipython/ipython PR). Since ZMQInteractiveShell overrides system_piped() for Windows UNC path handling, it needs to also check the system_raise_on_error config and raise CalledProcessError on non-zero exit status. Changes: - Import CalledProcessError from subprocess - Capture exit_code from system() call - Raise CalledProcessError when system_raise_on_error is True and exit_code is non-zero This enables Jupyter notebook users to halt execution on shell command failures when they opt-in via: get_ipython().system_raise_on_error = True
configuration option in ZMQInteractiveShell.system_piped() override. This complements IPython PR #15073 (ipython/ipython#15073) that adds the system_raise_on_error config option. Since ZMQInteractiveShell overrides system_piped() for Windows UNC path handling, it needs to also check the system_raise_on_error config and raise CalledProcessError on non-zero exit status.
for more information, see https://pre-commit.ci
adityawasudeo
force-pushed
the
add-system-raise-on-error
branch
from
196605f to
4467887
Compare
Author
@ianthomas23 Done. It looks like one of the windows tests is potentially flaky? I see it failed with an asyncio issue which seems unrelated to my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements iPython PR ipython/ipython#15073 which adds a new
system_raise_on_errorconfiguration option that raises CalledProcessError when shell commands executed via the ! operator return non-zero exit status. This brings similar error-handling behavior to the ! operator as was added to %%bash magic in PR ipython/ipython#11287.Since ZMQInteractiveShell
overrides system_piped() for Windows UNC path handling, it needs to
also check the system_raise_on_error config and raise CalledProcessError
on non-zero exit status.
Changes:
and exit_code is non-zero
This enables Jupyter notebook users to halt execution on shell
command failures when they opt-in via:
get_ipython().system_raise_on_error = True