Skip to content

fix(accordion): update tabindex based on disabled state#30986

Merged
thetaPC merged 2 commits intomainfrom
ROU-12588
Mar 5, 2026
Merged

fix(accordion): update tabindex based on disabled state#30986
thetaPC merged 2 commits intomainfrom
ROU-12588

Conversation

@os-davidlourenco
Copy link
Contributor

@os-davidlourenco os-davidlourenco commented Mar 3, 2026

Issue number: resolves internal


What is the current behavior?

When an accordion item was set as disabled, it was still possible to focus using keyboard navigation.

What is the new behavior?

When an accordion item is disabled, tabindex is set as -1 to stop being focusable using the keyboard navigation.

Does this introduce a breaking change?

  • Yes
  • No

Other information

preview

@os-davidlourenco os-davidlourenco requested a review from a team as a code owner March 3, 2026 13:19
@os-davidlourenco os-davidlourenco added the package: core @ionic/core package label Mar 3, 2026
@os-davidlourenco os-davidlourenco added the a11y Accessibility related issues label Mar 3, 2026
@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Mar 5, 2026 4:27pm

Request Review

@thetaPC thetaPC changed the title fix(accordion): update accordion tabindex based on disabled state fix(accordion): update tabindex based on disabled state Mar 4, 2026
@thetaPC thetaPC requested review from thetaPC and removed request for BenOsodrac March 4, 2026 18:49
@os-davidlourenco os-davidlourenco changed the base branch from next to main March 5, 2026 11:22
@os-davidlourenco os-davidlourenco changed the base branch from main to next March 5, 2026 11:23
@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Mar 5, 2026
@os-davidlourenco os-davidlourenco changed the base branch from next to main March 5, 2026 11:44
@github-actions github-actions bot removed package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Mar 5, 2026
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC thetaPC added this pull request to the merge queue Mar 5, 2026
Merged via the queue into main with commit 0e76a69 Mar 5, 2026
65 of 74 checks passed
@thetaPC thetaPC deleted the ROU-12588 branch March 5, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility related issues package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants