Skip to content

Synchronize only the storage definition when compiling *.cls documents#1730

Merged
isc-klu merged 17 commits intointersystems-community:masterfrom
isc-klu:master
Apr 8, 2026
Merged

Synchronize only the storage definition when compiling *.cls documents#1730
isc-klu merged 17 commits intointersystems-community:masterfrom
isc-klu:master

Conversation

@isc-klu
Copy link
Copy Markdown
Collaborator

@isc-klu isc-klu commented Mar 4, 2026

Fix #1729:

  • Added a new setting: refreshClassesOnSync: boolean = false
  • Updated the import and compile logic so that when refreshClassesOnSync is false, only the storage sections of *.cls files are synchronized with the server version, rather than the entire file content

@isc-klu isc-klu requested a review from isc-bsaviano as a code owner March 4, 2026 21:26
@gjsjohnmurray
Copy link
Copy Markdown
Contributor

I think this should be behind a setting, as there may be users who like the original behaviour.

@isc-bsaviano
Copy link
Copy Markdown
Contributor

Hi @gjsjohnmurray, we plan to put this behind a setting with the default being the new behavior. We also plan to make a DC post requesting feedback from users before merging.

@isc-klu
Copy link
Copy Markdown
Collaborator Author

isc-klu commented Mar 5, 2026

Added the requested new setting (refreshClassesOnSync : boolean = false). When true, fall back to the current behavior.

Comment thread src/api/index.ts Outdated
Comment thread src/commands/compile.ts
Comment thread src/commands/compile.ts Outdated
Comment thread src/commands/compile.ts Outdated
Comment thread src/commands/compile.ts Outdated
Comment thread src/utils/documentIndex.ts Outdated
@isc-klu isc-klu requested a review from isc-kcressma March 6, 2026 16:57
Comment thread src/commands/compile.ts Outdated
Comment thread src/commands/compile.ts Outdated
Comment thread src/commands/compile.ts Outdated
Comment thread src/api/index.ts
Comment thread package.json Outdated
@isc-bsaviano

This comment was marked as resolved.

Comment thread src/commands/compile.ts
@isc-klu
Copy link
Copy Markdown
Collaborator Author

isc-klu commented Mar 16, 2026

Feel free to try the new feature by installing the beta extension build:

vscode-objectscript-3.6.1-storage.1.vsix.zip

isc-bsaviano
isc-bsaviano previously approved these changes Apr 1, 2026
@isc-klu isc-klu merged commit 39072cd into intersystems-community:master Apr 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve Custom Formatting When Compiling Client‑Side Class (*.cls) Documents

3 participants