feat: add new remuxer to normalize media within milliseconds#38
Open
bajankristof wants to merge 1 commit intomainfrom
Open
feat: add new remuxer to normalize media within milliseconds#38bajankristof wants to merge 1 commit intomainfrom
bajankristof wants to merge 1 commit intomainfrom
Conversation
bajankristof
force-pushed
the
feat/remux
branch
2 times, most recently
from
67c32c6 to
81d9462
Compare
kiskoza
requested changes
Mar 9, 2026
| # @return [String] | ||
| # @raise [Errno::ENOENT] If the exiftool binary is not an executable. | ||
| def exiftool_binary=(path) | ||
| if path.is_a?(String) && !File.executable?(path) |
Contributor
There was a problem hiding this comment.
what if the path is not a String? if we plan to handle nil, then please add it to the method docs. if it's just a sanity check to make sure the File.executable? works, then add a proper error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.