detect remote document URL replacements during sync#12
Open
paulsonnentag wants to merge 1 commit intomainfrom
Open
detect remote document URL replacements during sync#12paulsonnentag wants to merge 1 commit intomainfrom
paulsonnentag wants to merge 1 commit intomainfrom
Conversation
Add URL replacement detection in ChangeDetector: when a peer replaces a document entirely (creating a new URL in the directory entry), the old snapshot-centric scan misses it. Now detected during the directory walk when a path's URL differs from the snapshot entry. Also add prettier for code formatting and remoteUrl field to DetectedChange. Made-with: Cursor
Member
|
could you add a failing test for this and show that this fixes it?
the current configuration is "whatever claude outputs" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add URL replacement detection in ChangeDetector: when a peer replaces a document entirely (creating a new URL in the directory entry), the old snapshot-centric scan misses it. Now detected during the directory walk when a path's URL differs from the snapshot entry.
I've decided it's better to make a relative local change instead of reconciling this problem properly.
I tried to match the current code formatting with the .prettierrc. I couldn't figure out fully what configuration the code currently uses. I can fix this if you let me know what configuration you are using