ext/pgsql: route pg_copy_from table_name through build_tablename#55
Closed
ext/pgsql: route pg_copy_from table_name through build_tablename#55
Conversation
The COPY query for pg_copy_from embedded the table_name argument with a raw "%s", so a caller-supplied name like `t FROM STDIN --` redirected the data into a different table than the API documents. Use the same build_tablename helper that pg_insert/update/select/delete have used since bug #62978. pg_copy_to is unchanged because COPY ... TO accepts a parenthesised query as a source spec, which the existing test 06_bug73498 relies on.
Owner
Author
|
Superseded by upstream PR php#21985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the table validation added in bug #62978 (which fixed pg_insert, pg_update, pg_select, pg_delete) but missed pg_copy_from. Not updating pg_copy_to since it allows (query) for the table name per ext/pgsql/tests/06_bug73498.phpt.