Conversation
|
vidarl
commented
Apr 15, 2026
| ? $fieldValue->data['imageId'] | ||
| : null), | ||
| 'width' => (isset($fieldValue->data['width']) | ||
| 'width' => ($fieldValue->data['width'] ?? '') !== '' |
Contributor
Author
There was a problem hiding this comment.
Seems to be the most convenient place to do this check, but is this the correct place to add it?
Alternatives are:
- in fromHash() (Don't think we ever do validation checking here ? )
- in Value\construct()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
In 5.0, strict typing was added to width and height in ImageVariation.php. (It was not added to Image\Value.php though)
I am not able to reproduce this on a fresh 5.0 database, but if you have upgraded from older version, you might have width and/or height set to empty value
””, ie:If you then try to load this image in admin-ui, it wlll crash due do violation of strict typing:
For QA:
See my comment from Apr 07, 2026 12:17 on https://support.ibexa.co/tickets/view/ISD-26496
Documentation: